[nrf noup] Provide a workaround for Factory Data support on nRF54H #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 30, 2024
|
|
||
| # If the location of the factory data is defined as an alias, | ||
| # add the base address to the factory data offset | ||
| # to get the proper offset calcualted from the base memory location. |
There was a problem hiding this comment.
Suggested change
| # to get the proper offset calcualted from the base memory location. | |
| # to get the proper offset calculated from the base memory location. |
| @@ -36,7 +36,12 @@ | |||
| #else | |||
| #include <zephyr/storage/flash_map.h> | |||
| #define FACTORY_DATA_SIZE DT_REG_SIZE(DT_ALIAS(factory_data)) | |||
| #define FACTORY_DATA_LOCATION_ADDRESS DT_REG_ADDR(DT_ALIAS(factory_data_location)) | |||
There was a problem hiding this comment.
Is it going to pass the compilation if factory_data_location does not exist?
There was a problem hiding this comment.
Hmm, I've done some tests locally and it seems to work.
kkasperczyk-no
approved these changes
Oct 31, 2024
| @@ -36,7 +36,12 @@ | |||
| #else | |||
| #include <zephyr/storage/flash_map.h> | |||
| #define FACTORY_DATA_SIZE DT_REG_SIZE(DT_ALIAS(factory_data)) | |||
| #define FACTORY_DATA_LOCATION_ADDRESS DT_REG_ADDR(DT_ALIAS(factory_data_location)) | |||
There was a problem hiding this comment.
Hmm, I've done some tests locally and it seems to work.
Until we do not have a proper solution for merging the factory data hex file with the firmware hex file, we need to flash the factory data manually. This commit allows doing that on nRF54H20 DK. Signed-off-by: Arkadiusz Balys <[email protected]>
ArekBalysNordic
force-pushed
the
nrf54h20_factory_data_workaround
branch
from
8cd5f5f to
a560ba9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until we do not have a proper solution for merging the factory data hex file with the firmware hex file, we need to flash the factory data manually. This commit allows doing that on nRF54H20 DK.