Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf noup][zephyr] Enabled support for bonding in the BLEManager #373

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

kkasperczyk-no
Copy link
Contributor

Currently the Zephyr BLE Manager rotates Bluetooth addresses on every boot and it does this by creating new Bluetooth identity. Because of that the Zephyr stack does not create default Bluetooth ID, which is required e.g. for the bonding purposes.

Added creating two separate Bluetooth identities - for the Matter service advertising and for the bonding purposes.

src/platform/Zephyr/BLEAdvertisingArbiter.cpp Show resolved Hide resolved
src/platform/Zephyr/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
src/platform/Zephyr/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
src/platform/Zephyr/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Damian-Nordic Damian-Nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some readability nits from me.

src/platform/Zephyr/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
src/platform/Zephyr/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
src/platform/Zephyr/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
src/platform/Zephyr/BLEManagerImpl.cpp Outdated Show resolved Hide resolved
Currently the Zephyr BLE Manager rotates Bluetooth addresses
on every boot and it does this by creating new Bluetooth identity.
Because of that the Zephyr stack does not create default Bluetooth
ID, which is required e.g. for the bonding purposes.

Added creating two separate Bluetooth identities - for the Matter
service advertising and for the bonding purposes.

Signed-off-by: Kamil Kasperczyk <[email protected]>
@kkasperczyk-no kkasperczyk-no merged commit 5ae6384 into nrfconnect:master Jan 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants