-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nrf noup] [nrfconnect] Added FactoryDataProviderBase #371
Merged
markaj-nordic
merged 1 commit into
nrfconnect:master
from
markaj-nordic:factory_data_proxy
Jan 4, 2024
Merged
[nrf noup] [nrfconnect] Added FactoryDataProviderBase #371
markaj-nordic
merged 1 commit into
nrfconnect:master
from
markaj-nordic:factory_data_proxy
Jan 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markaj-nordic
requested review from
kkasperczyk-no,
Damian-Nordic and
ArekBalysNordic
December 19, 2023 15:01
markaj-nordic
changed the title
[nrf noup] [nrfconnect] Added FactoryDataProxy
[nrf noup] [nrfconnect] Added FactoryDataProviderProxy
Dec 19, 2023
7 tasks
markaj-nordic
force-pushed
the
factory_data_proxy
branch
2 times, most recently
from
December 20, 2023 06:42
1ac2023
to
ade930c
Compare
kkasperczyk-no
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we discussed F2F, LGTM overall, I left only one small suggestion.
markaj-nordic
force-pushed
the
factory_data_proxy
branch
3 times, most recently
from
January 4, 2024 15:04
1c635f3
to
cad1641
Compare
markaj-nordic
changed the title
[nrf noup] [nrfconnect] Added FactoryDataProviderProxy
[nrf noup] [nrfconnect] Added FactoryDataProviderBase
Jan 4, 2024
Damian-Nordic
approved these changes
Jan 4, 2024
markaj-nordic
force-pushed
the
factory_data_proxy
branch
from
January 4, 2024 15:07
cad1641
to
ddc559b
Compare
assignments of FactoryDataProvider concrete types to to the generic pointer. Signed-off-by: Marcin Kajor <[email protected]>
markaj-nordic
force-pushed
the
factory_data_proxy
branch
from
January 4, 2024 15:17
ddc559b
to
407e800
Compare
ArekBalysNordic
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to facilitate dynamic assignments of FactoryDataProvider concrete types to to the generic pointer.