Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf noup] [nrfconnect] Added FactoryDataProviderBase #371

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

markaj-nordic
Copy link
Contributor

... to facilitate dynamic assignments of FactoryDataProvider concrete types to to the generic pointer.

@markaj-nordic markaj-nordic changed the title [nrf noup] [nrfconnect] Added FactoryDataProxy [nrf noup] [nrfconnect] Added FactoryDataProviderProxy Dec 19, 2023
@markaj-nordic markaj-nordic force-pushed the factory_data_proxy branch 2 times, most recently from 1ac2023 to ade930c Compare December 20, 2023 06:42
Copy link
Contributor

@kkasperczyk-no kkasperczyk-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed F2F, LGTM overall, I left only one small suggestion.

src/platform/nrfconnect/FactoryDataProvider.h Outdated Show resolved Hide resolved
src/platform/nrfconnect/FactoryDataProvider.h Outdated Show resolved Hide resolved
src/platform/nrfconnect/FactoryDataProvider.h Outdated Show resolved Hide resolved
src/platform/nrfconnect/FactoryDataProvider.h Outdated Show resolved Hide resolved
@markaj-nordic markaj-nordic force-pushed the factory_data_proxy branch 3 times, most recently from 1c635f3 to cad1641 Compare January 4, 2024 15:04
@markaj-nordic markaj-nordic changed the title [nrf noup] [nrfconnect] Added FactoryDataProviderProxy [nrf noup] [nrfconnect] Added FactoryDataProviderBase Jan 4, 2024
assignments of FactoryDataProvider concrete types to
to the generic pointer.

Signed-off-by: Marcin Kajor <[email protected]>
@markaj-nordic markaj-nordic merged commit 496275a into nrfconnect:master Jan 4, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants