[nrf noup] Enhance/Optimize attach to thread network #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doublemis1
requested review from
kkasperczyk-no,
ArekBalysNordic,
markaj-nordic and
Damian-Nordic
Damian-Nordic
approved these changes
Sep 8, 2023
| Thread::OperationalDataset current_dataset; | ||
| // Validation the dataset change with the current state | ||
| ThreadStackMgrImpl().GetThreadProvision(current_dataset); | ||
| if (!dataset.AsByteSpan().data_equal(current_dataset.AsByteSpan())) |
There was a problem hiding this comment.
Hmm, maybe you could just do sth like:
if (dataset.AsByteSpan().data_equal(current_dataset.AsByteSpan() && callback == nullptr)
{
return CHIP_NO_ERROR;
}
- If the callback is provided, we probably want to restart the interface. Otherwise, the callback will never be called, so if a user called
ConnectNetworkfor the second time, it would fail (I don't know why a user would want to do it, but it should probably work). - If the callback is not provided we don't need to execute
if (dataset.IsCommissioned())code.
doublemis1
force-pushed
the
ignore_reset_thread_interface
branch
from
658585d to
c9d3034
Compare
|
Tested after update on NCS 2.2.0 Door Lock NRF52840: |
Would creating a known issue with a recommendation to cherry-pick this commit work? Btw. could you open a PR to sdk-nrf with manifest change pointing to this PR? We need to test it against NCS main to be able to merge it. |
kkasperczyk-no
approved these changes
Sep 11, 2023
markaj-nordic
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
@doublemis1 Please open the sdk-nrf PR with bumped manifest.
src/platform/OpenThread/GenericThreadStackManagerImpl_OpenThread.cpp
Outdated
Show resolved
Hide resolved
Enhance attaching to Thread by verifying if the current dataset is the same as provided. In current solution implementation will not reset the Thread interface while the dataset are equal to the active dataset. Signed-off-by: Michał Szablowski <[email protected]>
doublemis1
force-pushed
the
ignore_reset_thread_interface
branch
from
c9d3034 to
860dc14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhance attaching to Thread by verifying if the current dataset is the same as provided.
In current solution implementation will not reset the Thread interface while the
dataset are equal to the active dataset.