[nrf noup] config: nrfconnect: Define _DEFAULT_SOURCE #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the chip-module build configurations to define `_DEFAULT_SOURCE` when compiling Matter because it uses non-standard functions that are only available when `_DEFAULT_SOURCE` is defined. Note that this used to be not necessary only because of a quirk in the way Newlib handles the feature test macro, which resulted in Newlib defining `_DEFAULT_SOURCE` when compiling with `-std=gnu`. For more details, refer to the issue zephyrproject-rtos/zephyr#52739. Signed-off-by: Stephanos Ioannidis <[email protected]>
Damian-Nordic
approved these changes
Dec 2, 2022
nordicjm
approved these changes
Dec 2, 2022
|
The CI failures seem to be unrelated to the changes in this PR. sdk-nrf side CI passed: Ready to be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the chip-module build configurations to define
_DEFAULT_SOURCEwhen compiling Matter because it uses non-standard functions that are only available when_DEFAULT_SOURCEis defined.Note that this used to be not necessary only because of a quirk in the way Newlib handles the feature test macro, which resulted in Newlib defining
_DEFAULT_SOURCEwhen compiling with-std=gnu.For more details, refer to the issue zephyrproject-rtos/zephyr#52739.
Signed-off-by: Stephanos Ioannidis [email protected]