Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

made sda and scl public for i2c interfaces #151

Merged
merged 1 commit into from
Aug 2, 2024
Merged

made sda and scl public for i2c interfaces #151

merged 1 commit into from
Aug 2, 2024

Conversation

BartMassey
Copy link
Member

Made the sda and scl pins in the various I2c Pins struct public.

Closes #150

@qwandor
Copy link
Member

qwandor commented Jul 30, 2024

Please add this to the changelog.

@qwandor qwandor self-requested a review July 30, 2024 18:53
@BartMassey BartMassey force-pushed the i2c-pins-pub branch 2 times, most recently from c4c6fb3 to 79186f9 Compare July 30, 2024 20:49
@BartMassey
Copy link
Member Author

Done. Also fixed a screwup. Apologies.

Will fix the MSRV break in a moment.

@BartMassey
Copy link
Member Author

Nope. Fix did not work. Help figuring this out appreciated. MSRV workflow exits with status 101, no obvious log message I could see.

@BartMassey
Copy link
Member Author

Looks like the version of fixed used by nrf51-hal requires Rust 1.78.0 even on feature embedded-hal-02. Bummer.

Shall we update the MSRV of this, or shall I try to get a fix in upstream?

@qwandor
Copy link
Member

qwandor commented Jul 30, 2024

Weird, what changed to break that? Personally I don't mind updating the MSRV, but I'd like to understand what caused it to break.

@BartMassey
Copy link
Member Author

Looks like the version of fixed used in nrf-hal got bumped from 1.0.0 to 1.25.1 on 2024-03-06 when nrf-hal was being prepared for 0.18 release. The new fixed has an MSRV.

qwandor
qwandor reviewed Aug 2, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -10,6 +10,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
- Set MSRV for `microbit` and `microbit-v2` crates.
- Bumped MSRV to 1.79.0.

## [0.15.1] - 2024-07-30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should include the items under the 'Unreleased' heading above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed, thanks much.

@qwandor qwandor added this pull request to the merge queue Aug 2, 2024
Merged via the queue into nrf-rs:main with commit 63fa7c2 Aug 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwandor qwandor qwandor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No way to take ownership of the individual i2c pins without losing their type
2 participants
@BartMassey @qwandor