Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #31] load-file should return value of last expression #32

Closed
wants to merge 2 commits into from

Conversation

danskarda
Copy link

For detailed discussion see #31 and clojure-emacs/cider#830

@danskarda danskarda changed the title load-file should return value of last expression #31 [Fix #31] load-file should return value of last expression Sep 29, 2014
@danskarda
Copy link
Author

Second commit adds a support for in-ns during loading. Without support for in-ns, ClojureScript eval is slow in CIDER.

@cemerick Please, please, pretty please, merge the fix and release new version. Without it ClojureScript evaluation is second class citizen in CIDER: slow and without results and exceptions. Unfortunately both issues are result of your solution proposed in http://dev.clojure.org/jira/browse/NREPL-59

/cc @bbatsov

@bbatsov
Copy link
Contributor

bbatsov commented Dec 5, 2014

@cemerick I think that the second commit in the PR is pretty sensible. There's nothing bad in supporting in-ns during load-file, right?

@cemerick
Copy link
Collaborator

cemerick commented Dec 5, 2014

Reopening to consider the in-ns issue later.

@cemerick
Copy link
Collaborator

I released 0.2.0 today, which is effectively a rewrite in order to accommodate the upstream changes in ClojureScript's provided REPL machinery. This has eliminated many, many issues caused by piggieback's previous implementation (both in the details and strategy). Closing this now, since the environment is entirely different now (load-file is implemented as its own operation, not a transform over arguments to the default Clojure load-file impl, etc).

@cemerick cemerick closed this Mar 31, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants