Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Layer "Mapillary" is currently not populated with coverage #432

Closed
cmuerau opened this issue Jun 22, 2021 · 4 comments
Closed

Layer "Mapillary" is currently not populated with coverage #432

cmuerau opened this issue Jun 22, 2021 · 4 comments
Labels
bug
Milestone
0.18.0

Comments

@cmuerau
Copy link

cmuerau commented Jun 22, 2021

On June 10, 2021, Mapillary announced a Platform update being live with a lot of detail changes missing. Since then discussion there and in other threads as well tries to figure out all changes on all affected apps, instances, etc.

Is it possible that the API change from v3 to v4 is responsible for currently not populating the layer with image positions?
@rkflx
Copy link
Contributor

rkflx commented Jun 22, 2021

Thank you for the heads-up!

The issue is that the domain d6a1v2w10ny40.cloudfront.net used for serving the coverage tiles cannot be resolved anymore (see error console in your browser's dev tools).

Once the dust of the Mapillary migration has settled, we can try to find the new tiles URL / API endpoint (possibly with an API token to add to keys.template.js), and update mapillary-coverage-raster.geojson.

However, the new v4 API docs only reference vector tiles so far, while we used raster tiles before. This might need more involved changes.

If a solution is not in sight before the next BRouter-Web release, I'd suggest to disable the overlay for now, since there is no point in shipping something broken.

See also #153 and #289.

@nrenner nrenner added the bug label Jun 26, 2021
@nrenner nrenner added this to the next milestone Jun 26, 2021
nrenner added a commit that referenced this issue Jun 17, 2022
@nrenner
Replace Mapillary raster with vector tiles (#432)
d5a6a0a
@nrenner
Copy link
Owner

nrenner commented Jun 17, 2022

I haven't found any comment on the raster tile layer, only a question without answer: "New Mapillary TMS url?".

So switched to vector tiles, now that we have MapLibre GL JS integrated, see d5a6a0a.

@nrenner nrenner closed this as completed Jun 17, 2022
@nrenner nrenner modified the milestones: next, 0.18.0 Jun 17, 2022
stefankeidel added a commit to cxberlin/brouter-web that referenced this issue Jun 25, 2022
@stefankeidel
Merge remote-tracking branch 'upstream/master'
985d1bb 
* upstream/master:
  Allow release tasks to be called individually
  release: 0.18.0
  Fix trekking profile not loaded
  Disable babel transpiling of import() call
  Update changelog for 0.18.0
  Update translations
  Update dependency eslint to v8.18.0 (nrenner#563)
  Update dependency i18next-scanner to v3.3.0 (nrenner#562)
  Update dependency prettier to v2.7.1 (nrenner#560)
  Update dependency @babel/core to v7.18.5 (nrenner#559)
  Update dependency marked to v4.0.17 (nrenner#558)
  Prevent sporadic canvas mouseout bubbling to map
  Fix global assignments
  Map old Mapillary raster layer id to new
  Document vector tile layers
  Replace Mapillary raster with vector tiles (nrenner#432)
  Support access tokens for Maplibre (mvt) tile urls
  Configure hillshading layer
  Replace HikeBike.HillShading layer id
  Lazy load Maplibre GL JS and add hillshading layer
@govvin
Copy link

govvin commented Jul 25, 2022

Glad to see this back, and have a question about the Mapillary layer.

Is it possible to color the layer by capture date, similar to an option found from Mapillary's web viewer?
image

@nrenner
Copy link
Owner

nrenner commented Jul 26, 2022

Would need to check, but should be possible now.

Could you please move this to a new issue?

@govvin govvin mentioned this issue Jul 26, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.18.0
Development

No branches or pull requests
4 participants
@nrenner @govvin @cmuerau @rkflx