[Maps] Improving design and a11y for attribution layer settings #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
reviewed
Apr 30, 2021
There was a problem hiding this comment.
Thanks for putting together a new design for the the attribution.
Would it be possible to remove the horizontal line and keep the columnCompressed form row? The new design makes the attribution really stand out while its no more important then any of the other rows.
| @@ -1,3 +1,3 @@ | |||
| .mapAttributionPopover { | |||
| width: $euiSizeXXL * 12; | |||
| width: $euiSizeXXL * 8; | |||
There was a problem hiding this comment.
Can we keep the original size? URLs can get very long and having more horizontal space makes the text input more usable.
There was a problem hiding this comment.
Yes, I'll try to add some styles to make it more similar to the columnCompressed form row. I'll also try to remove the horizontal line.
|
@nreese here's the new design updates based on your feedback:
|
|
@miukimiu That looks fantastic. Thank you |
|
@nreese can you merge it?
|
|
I have merged the changes, thanks |
nreese
added a commit
that referenced
this pull request
May 3, 2021
* [Maps] add attribution to layer editor * update sources to getAttributionProvider * remove attribution UI from EMS_XYZ source * remove attribution UI from WMS source editor * clean up * tslint * AttributionFormRow jest test * add migration * tslint * i18n fixes * attribution * [Maps] Improving design and a11y for attribution layer settings (#38) * Design and a11y improvements * Buttons aria labels * Addressing PR review * tslint and i18n fixes * update jest snapshots * remove placeholder for url Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Elizabet Oliveira <[email protected]>
nreese
added a commit
that referenced
this pull request
May 4, 2021
* [Maps] add attribution to layer editor * update sources to getAttributionProvider * remove attribution UI from EMS_XYZ source * remove attribution UI from WMS source editor * clean up * tslint * AttributionFormRow jest test * add migration * tslint * i18n fixes * attribution * [Maps] Improving design and a11y for attribution layer settings (#38) * Design and a11y improvements * Buttons aria labels * Addressing PR review * tslint and i18n fixes * update jest snapshots * remove placeholder for url Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Elizabet Oliveira <[email protected]>
nreese
added a commit
that referenced
this pull request
May 5, 2021
* [Maps] add attribution to layer editor * update sources to getAttributionProvider * remove attribution UI from EMS_XYZ source * remove attribution UI from WMS source editor * clean up * tslint * AttributionFormRow jest test * add migration * tslint * i18n fixes * attribution * [Maps] Improving design and a11y for attribution layer settings (#38) * Design and a11y improvements * Buttons aria labels * Addressing PR review * tslint and i18n fixes * update jest snapshots * remove placeholder for url Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Elizabet Oliveira <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Elizabet Oliveira <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
a11y changes
<fieldset />to signal that we're going to have a group of related form fields<fieldset />.aria-labelfor buttons.Design