Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Kibana 7.6 #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support for Kibana 7.6 #64

wants to merge 1 commit into from

Conversation

ch-bas
Copy link

@ch-bas ch-bas commented Jun 5, 2020

Support for Kibana 7.6

@ch-bas ch-bas mentioned this pull request Jun 5, 2020
@francisco-hoo
Copy link

Hi @ch-bas, do you have any idea of what you need to close this?

@ch-bas
Copy link
Author

ch-bas commented Jun 18, 2020

Hi @francisco-hoo , I think this will not be closed and merged as long as the maintainer announced that there is no plan for upcoming versions, you can try my fork meanwhile.

@RonnieDilli
Copy link

RonnieDilli commented Jun 19, 2020

Hi @francisco-hoo , I think this will not be closed and merged as long as the maintainer announced that there is no plan for upcoming versions, you can try my fork meanwhile.

@ch-bas Do you plan to make your fork compatible with Kibana 7.8 ?
I rely on this plugin to upgrade the stack but no luck since version 7.3.2 .

@francisco-hoo
Copy link

@RonnieDilli what you got when trying for >7.3.x ?

@RonnieDilli
Copy link

RonnieDilli commented Jun 19, 2020

@RonnieDilli what you got when trying for >7.3.x ?

@francisco-hoo

In an existing Dashboard on 7.7.0 and 7.8.0 the instead of the plugin contents, it says:
Invalid type "time"

as the image bellow:
image

The "Time Widget" is not even an option in "New Visualization".

I tried applying changes supplied in other issues and even @ch-bas branch, but no effect.
Also the Kibana console shows:
[kibana-time-plugin] are using the legacy plugin format and will no longer work in a future Kibana release. Please refer to https://ela.st/kibana-breaking-changes-8-0 for a list of breaking changes and https://ela.st/kibana-platform-migration for documentation on how to migrate legacy plugins."}

@RonnieDilli
Copy link

RonnieDilli commented Jun 19, 2020

At this time, I'm looking for upgrading to versions from 7.7.0 and above, since the new feature "Alerts" are a deal breaker for us.
So any help is appreciated.

@francisco-hoo
Copy link

Yes this is a problem related to the code... Elasticsearch remove support for legacy plugins, so since 7.x you must change some part of your code. Here you have some examples of migration from the previous versions to new ones.

@RonnieDilli
Copy link

Yes this is a problem related to the code... Elasticsearch remove support for legacy plugins, so since 7.x you must change some part of your code. Here you have some examples of migration from the previous versions to new ones.

Thank you Francisco, I suspect the code needed changes, but other forks haven't any.
Anyway, I'll attempt the changes and upload them to my fork, I hope it works.

@RonnieDilli
Copy link

This pull request may suppress the need for the plugin:

elastic/kibana#58435

@francisco-hoo
Copy link

This pull request may suppress the need for the plugin:

Yes @RobinELM but it will be interesting let people in previous versions have access to this feature too. Some people are using other plugins that requires a specific version of Kibana.
Is this pull request related to a play button with a start/end date to create an animation? Only seems to be a shareable link of a dashboard with start and end date..

@RonnieDilli
Copy link

RonnieDilli commented Jun 19, 2020

This pull request may suppress the need for the plugin:

Yes @RobinELM but it will be interesting let people in previous versions have access to this feature too. Some people are using other plugins that requires a specific version of Kibana.
Is this pull request related to a play button with a start/end date to create an animation? Only seems to be a shareable link of a dashboard with start and end date..

I understand it will allow you to choose some features when you share a dashboard, for example:

If you pick the Time Filter option it will show the default time picker while using an embedded dashboard.
Without the Time Filter you will be restrained to a start and end date, like you are nowadays anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants