This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Replaced all individual snippet indices with 'this' keyword #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <[email protected]>
Mierdin
changed the title
Signed-off-by: Matt Oswalt <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nre-learning/antidote-web#45 introduced the ability to use a consistent
thiskeyword instead of trying to keep track of which 0-based index a given snippet is at on a page. Thanks, @jnpr-raylam!So, we want to update all of the existing snippets in the curriculum. While the old index system is supported, the examples we want to put out there should use this, as it's simpler and will give us fewer headaches going forward.