Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

New Lesson - Automating with JET #173

Merged
merged 6 commits into from
Mar 26, 2019

Conversation

jnpr-raylam
Copy link
Contributor

@jnpr-raylam jnpr-raylam commented Feb 5, 2019

It's ready for review. Thanks.

Stage1: JET rpc/notification configuration
Stage2: Receive events from notification service using MQTT client
Stage3: IDL compilation and basic GRPC JET testing
Stage4: JET Firewall API to create/update firewall filter
Stage5: Closed loop automation with JET

Closes https://github.com/nre-learning/antidote/issues/164

@Mierdin
Copy link
Member

Mierdin commented Feb 9, 2019

Hey @jnpr-raylam thanks for this. I had hoped to be able to review this in time for the upcoming release this weekend, but there were a few problem that came up that needed addressed. Once v0.3.0 comes out in the next few days, I'll turn around and get your lesson reviewed so we can put it into v0.3.1, which will ideally drop the week after. Thanks for your patience.

@jnpr-raylam
Copy link
Contributor Author

@Mierdin any update on this? Thanks!

@Mierdin
Copy link
Member

Mierdin commented Mar 4, 2019

Thanks @jnpr-raylam. Will begin a full review shortly. Thanks for working on this.

Can you reword the title, though? "Automating with JET" doesn't really describe what's going on here, or what openconfig really is. "automating" can apply broadly to anything on this site. Maybe something like "The Junos Extensibility Toolkit (JET)"?

Copy link
Member

@Mierdin Mierdin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is.......really, really cool. Well done on this - only a few minor formatting changes and we'll get this merged.

As with your other PR, we'll need to make sure the images are switched around before we go to prod, but I'll take care of that post-merge.

Sincere apologies this took so long to review - great work, and I look forward to seeing this go live in the next release.

lessons/lesson-25/stage1/guide.md Outdated Show resolved Hide resolved
lessons/lesson-25/stage1/guide.md Outdated Show resolved Hide resolved
lessons/lesson-25/stage2/guide.md Outdated Show resolved Hide resolved
lessons/lesson-25/stage3/guide.md Outdated Show resolved Hide resolved
lessons/lesson-25/stage4/guide.md Outdated Show resolved Hide resolved
lessons/lesson-25/stage5/guide.md Outdated Show resolved Hide resolved
lessons/lesson-25/syringe.yaml Outdated Show resolved Hide resolved
lessons/lesson-25/syringe.yaml Outdated Show resolved Hide resolved
@Mierdin
Copy link
Member

Mierdin commented Mar 20, 2019

A quick update - I'm having a discussion in nre-learning/antidote-core#93 regarding one of things that's standing in the way of us using the new full vqfx image. Once that conversation is worked out I believe we'll be ready to use the new image. Stay tuned there for updates for now.

In the meantime, I'd like to keep this PR open so we can merge it when it's totally ready to go. I'd feel comfortable merging it now, but I'd have to keep it in PTR until the new image is ready to use, at which point we'd have to update this lesson to use it anyways. I'm still committed to getting this in the next release so we're really all just waiting for this image stuff to get hashed out and then all the pieces will fall into place. Thanks for your patience.

@Mierdin
Copy link
Member

Mierdin commented Mar 26, 2019

I've decided to merge this now, as the lesson itself is solid, and the image work being done in #208 and #206 can happen in parallel. I'd like to get this lesson merged sooner rather than later, because I am pretty sure the only PR that's waiting for this image work is #191, and it doesn't make sense to hold up the work done in this PR as well as #184 just for that.

Thanks again for this work!

@Mierdin Mierdin merged commit a4dfa2a into nre-learning:master Mar 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants