This repository has been archived by the owner on Dec 3, 2021. It is now read-only.
Use ingresses for iframe resources #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Oswalt <[email protected]>
Mierdin
changed the title
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Signed-off-by: Matt Oswalt <[email protected]>
Mierdin
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, iframe resources are a bit neglected. I moved to make them more generic, instead of specifically using jupyter notebooks, but this is still not ideal. In addition to the issue brought up in #27, the current method of exposing these via NodePort, in spite of the fact that EVERYTHING ELSE goes through the nginx ingress controller, is a bit silly, and the DNS based load balancing wasn't ever fully automated.
This PR solves both problems by having Syringe create Ingress objects for each iframe resource, so that the iframe within the antidote-web page is pointing to the exact same domain, using the same certs - just a different path, managed by the nginx controller.
TODOs
Closes #27