-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation on windows for some time zones, add lquadmath #972
Conversation
Testing on macOS Big Sur 11.7.4 |
@ftesser Will test when I have a few minutes. |
Compilation test completed succesfully. ✅ I agree to add this to the |
@ftessier Compiles fine on M2 MacBook Air, with Ventura 13.2.1 and GCC 12.2 from Homebrew. |
On Windows the lquadmath changes won't be applied until we recompile the configuration GUI and post it with the release. In the mean time, users can just add
You only need to do this if you can't compile applications and get an error about quadmath. |
Please review this soon, it's impacting a number of users trying to install the latest release of EGSnrc. |
Thanks, I will merge this one asap. |
I am merging this on |
Since we hadn't merged this in yet, I added a couple other fixes to windows compilation (original post updated). It seems that on windows, many users were installing git but then still using the zip file to install EGSnrc, which was causing issues. |
Fix a bug that occurred when the time zone was a long string on windows. This caused compilation of applications to fail on windows, complaining about the COMPILE_TIME definition, because the string was too long. Now, the time zone is not printed for windows.
Remove the timezone from the beamnrc.spec file when the COMPILE_TIME is printed, to avoid a line overflow for longer timezones.
Fix a compilation error on windows that occurred when the user had installed git, but did not clone EGSnrc using git. This resulted in a compiler error complaining about GIT_HASH. Also fix some warnings about the directory not being a git repository.
30f1a99
to
2d1a449
Compare
Fix a bug where applications would fail to compile on windows in locations where the time zone was a long string. This was due to the COMPILE_TIME flag that included some text about the time zone. To fix the issue, the time zone was removed from the variable and output.
Fix an issue where lquadmath was not included with lgfortran, and the compiler would fail on some systems.
Fix a compiler error that occurred when the user had installed git, but then installed EGSnrc using the zip file. Users would see an error about GIT_HASH not being defined in this case.
Fix a minor warning that was printed about it not being a git repository.
@ftessier please check that the lquadmath changes don't cause any issues on OS X. I recommend that we cherry pick these fixes into v2023.