Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix custom template instructions #45

Merged
merged 2 commits into from
Mar 13, 2018
Merged

Conversation

martinklepsch
Copy link
Contributor

@martinklepsch martinklepsch commented Feb 16, 2018

Just noticed that there's a small mismatch between implementation + documentation.

Wording could be done differently but I figured this is probably clearer than saying "if there's a directory templates/ and a file template.md in this directory it is used..."

Maybe also the implementation is wrong and the docs are correct? 😆

@koppor
Copy link
Contributor

koppor commented Feb 19, 2018

At #43 we added a custom template, which was more work, because we define headings and links in a slightly different way.

We also improved the finding of templates at https://github.com/npryce/adr-tools/pull/43/files#diff-f72c445542852eb903c03519fa554d54R80 First, the sub directory templates of the ADRs is checked, then ADR dir itslef, then the adr_template_dir.

@npryce
Copy link
Owner

npryce commented Mar 13, 2018

Yes, I prefer this wording.

@npryce npryce closed this Mar 13, 2018
@npryce npryce reopened this Mar 13, 2018
@npryce npryce merged commit 81bb453 into npryce:master Mar 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants