This repository has been archived by the owner on Mar 26, 2021. It is now read-only.
Set post categories during import. #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeremyDunn
force-pushed
the
set-post-categories
branch
from
b69e447
to
edd06aa
Compare
CrookedNumber
added a commit
that referenced
this pull request
Nov 19, 2014
Set post categories during import.
|
Seems like a sound idea; basic testing looks good. |
|
Tiny footnote here: I'm pretty sure that categories in the API are mutually exclusive; in other words, you can place your story in only one category. So, technically, this code is overly thorough. That being said, I'm more than happy to sacrifice a few ms (esp. since this is on the admin side) in order to future-proof this functionality. |
|
Thanks for the info. I'd be happy to simplify it in a new PR if you'd like. |
|
Nah, but thank you. If this were rifling through 1000's of XML elements and/or happening on the front-end, this would make me worry. And as I said, I like its exhaustiveness, even if its slightly unnecessary (as of now). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the categories for an imported story if the categories exist in Wordpress.