fix: pass releases to publish check #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/abundant-brave-insect
branch
from
3fffeee to
650d56f
Compare
wraithgar
approved these changes
May 7, 2024
Merged
hashtagchris
pushed a commit
that referenced
this pull request
Jul 16, 2024
🤖 I have created a release *beep* *boop* --- ## [4.23.0](v4.22.0...v4.23.0) (2024-06-27) ### Features * [`60ee94f`](60ee94f) [#447](#447) add prettier support (@lukekarrys, @jumoel) ### Bug Fixes * [`b35bca5`](b35bca5) [#447](#447) run prettier (@lukekarrys) * [`8aef509`](8aef509) [#446](#446) dont conclude checks if they were never set (#446) (@lukekarrys) * [`9440c4f`](9440c4f) [#444](#444) pass releases to publish check (#444) (@lukekarrys) ### Dependencies * [`8252fb2`](8252fb2) [#452](#452) bump release-please from 16.10.2 to 16.12.0 (#452) (@dependabot[bot], @wraithgar) ### Chores * [`b07d17a`](b07d17a) [#448](#448) add .git-blame-ignore-revs for initial prettier (#448) (@lukekarrys) * [`210247e`](210247e) [#447](#447) add prettier:true to template-oss config (@lukekarrys, @jumoel) * [`1a073e4`](1a073e4) [#443](#443) bump @npmcli/template-oss to 4.22.0 (@lukekarrys) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Aug 7, 2024
This was referenced Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
publish: trueis not set, then the release intergration workflow falls back to runningnpm view $SPECwhich will error if the package has not been published. This tags the CODEOWNERS in the release issue so we know something went wrong.This doesn't have much use now that we are moving everything to
publish: truebut it would have caught a missing publish last week that I missed on@npmcli/fs: https://github.com/npm/fs/actions/runs/8946801618/job/24577963034#step:7:4The
RELEASESenv var was only being set for the publish step, not the check if published step.