Skip to content

Commit

Permalink
fix: use commitlint config via rc file only (#95)
Browse files Browse the repository at this point in the history
  • Loading branch information
lukekarrys authored Mar 17, 2022
1 parent 8b9afdc commit dd84416
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 24 deletions.
9 changes: 3 additions & 6 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,13 +29,10 @@ jobs:
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- name: Install deps
run: |
npm i -D @commitlint/cli @commitlint/config-conventional
run: npm i -D @commitlint/cli @commitlint/config-conventional
- name: Check commits OR PR title
env:
PR_TITLE: ${{ github.event.pull_request.title }}
run: |
npx commitlint -x @commitlint/config-conventional -V \
--from origin/main --to ${{ github.event.pull_request.head.sha }} \
|| echo $PR_TITLE | \
npx commitlint -x @commitlint/config-conventional -V
npx --offline commitlint -V --from origin/main --to ${{ github.event.pull_request.head.sha }} \
|| echo $PR_TITLE | npx --offline commitlint -V
9 changes: 3 additions & 6 deletions lib/content/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,10 @@ jobs:
{{> setupGit with=(obj fetch-depth=0)}}
{{> setupNode}}
- name: Install deps
run: |
npm i -D @commitlint/cli @commitlint/config-conventional
run: npm i -D @commitlint/cli @commitlint/config-conventional
- name: Check commits OR PR title
env:
PR_TITLE: $\{{ github.event.pull_request.title }}
run: |
npx commitlint -x @commitlint/config-conventional -V \
--from origin/main --to $\{{ github.event.pull_request.head.sha }} \
|| echo $PR_TITLE | \
npx commitlint -x @commitlint/config-conventional -V
npx --offline commitlint -V --from origin/main --to $\{{ github.event.pull_request.head.sha }} \
|| echo $PR_TITLE | npx --offline commitlint -V
18 changes: 6 additions & 12 deletions tap-snapshots/test/apply/full-content.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -369,16 +369,13 @@ jobs:
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- name: Install deps
run: |
npm i -D @commitlint/cli @commitlint/config-conventional
run: npm i -D @commitlint/cli @commitlint/config-conventional
- name: Check commits OR PR title
env:
PR_TITLE: \${{ github.event.pull_request.title }}
run: |
npx commitlint -x @commitlint/config-conventional -V /
--from origin/main --to \${{ github.event.pull_request.head.sha }} /
|| echo $PR_TITLE | /
npx commitlint -x @commitlint/config-conventional -V
npx --offline commitlint -V --from origin/main --to \${{ github.event.pull_request.head.sha }} /
|| echo $PR_TITLE | npx --offline commitlint -V
.github/workflows/release-please.yml
========================================
Expand Down Expand Up @@ -1034,16 +1031,13 @@ jobs:
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- run: npm -v
- name: Install deps
run: |
npm i -D @commitlint/cli @commitlint/config-conventional
run: npm i -D @commitlint/cli @commitlint/config-conventional
- name: Check commits OR PR title
env:
PR_TITLE: \${{ github.event.pull_request.title }}
run: |
npx commitlint -x @commitlint/config-conventional -V /
--from origin/main --to \${{ github.event.pull_request.head.sha }} /
|| echo $PR_TITLE | /
npx commitlint -x @commitlint/config-conventional -V
npx --offline commitlint -V --from origin/main --to \${{ github.event.pull_request.head.sha }} /
|| echo $PR_TITLE | npx --offline commitlint -V
.github/workflows/release-please-bbb.yml
========================================
Expand Down

0 comments on commit dd84416

Please sign in to comment.