Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE(install): default to --install-links=true #510

Closed
Tracked by #443
darcyclarke opened this issue May 16, 2022 · 2 comments · Fixed by npm/cli#5458
Closed
Tracked by #443

BREAKING CHANGE(install): default to --install-links=true #510

darcyclarke opened this issue May 16, 2022 · 2 comments · Fixed by npm/cli#5458
Assignees
@wraithgar
Labels
feature
Milestone
v9.0.0

Comments

@darcyclarke
Copy link
Contributor

darcyclarke commented May 16, 2022 •
edited
Loading

Summary

In v7 we stopped installing linked deps, in v8 we added the flag --install-links to accommodate this use case. In v9 we should make this the default again (ie. --install-links=true)
@darcyclarke darcyclarke mentioned this issue May 16, 2022
Closed
32 tasks
@darcyclarke darcyclarke changed the title BREAKING CHANGE(install): default to <code class="notranslate">--install-links=true` BREAKING CHANGE(install): default to --install-links=true May 16, 2022
wraithgar added a commit to npm/cli that referenced this issue Sep 1, 2022
@wraithgar
feat: default install-links to true
8bc2108 
BREAKING CHANGE: this changes the default value of `install-links` to
true

Closes npm/statusboard#510
@wraithgar wraithgar mentioned this issue Sep 1, 2022
Merged
@wraithgar wraithgar self-assigned this Sep 1, 2022
wraithgar added a commit to npm/cli that referenced this issue Sep 1, 2022
@wraithgar
feat: default install-links to true
d81d426 
BREAKING CHANGE: this changes the default value of `install-links` to
true

Closes npm/statusboard#510
@lukekarrys lukekarrys added this to the v9.0.0 milestone Sep 2, 2022
wraithgar added a commit to npm/cli that referenced this issue Sep 8, 2022
@wraithgar
feat: default install-links to true (#5458)
2a8c2fc 
BREAKING CHANGE: this changes the default value of `install-links` to
true

Closes npm/statusboard#510
@MylesBorins MylesBorins mentioned this issue Sep 28, 2022
Closed
1 task
@sacummings91
Copy link

Really confused by this change. This seems to break anywhere we are running npm install in docker or CI/CD because we use git submodules. Is this now the expected behavior? Do we always have to do npm install --no-install-links now?

@wraithgar
Copy link
Member

This was reverted in [email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wraithgar wraithgar

Labels
feature
Projects
None yet
Milestone
v9.0.0
Development

Successfully merging a pull request may close this issue.

feat: default install-links to true npm/cli
4 participants
@wraithgar @darcyclarke @lukekarrys @sacummings91