Epic: Debug Log File Redesign #367
Assignees
Labels
Comments
|
From a slack discussion today:
|
darcyclarke
changed the title
|
@lukekarrys can we close this issue out? |
lukekarrys
added a commit
to npm/cli
that referenced
this issue
Nov 30, 2021
This decouples the log file writing from the terminal logging. We now open an append only file at the start of the process and stream logs to it. We still only display the log file message in timing mode or if there is an error, but the file is still written regardless. All logging now goes through `proc-log` and his is the first step to removing `npmlog`. For now `npmlog` is still used for the terminal logging but with a shim in front of it to make it easier to test and use in conjunction with `proc-log`. Ref: npm/statusboard#366 This also refactors many of the tests to always use an explicit `t.testdir` for their cache since the file is opened on each `new Npm()`. Tests are also refactored to use more of `MockNpm` with behavior to add config items and load `npm` if necessary. A new fixture `mockGlobals` was also added to make much of this for ergonomic. Ref: npm/statusboard#410 Closes npm/statusboard#411 Closes npm/statusboard#367
lukekarrys
added a commit
to npm/cli
that referenced
this issue
Dec 1, 2021
This decouples the log file writing from the terminal logging. We now open an append only file at the start of the process and stream logs to it. We still only display the log file message in timing mode or if there is an error, but the file is still written regardless. All logging now goes through `proc-log` and this is the first step to removing `npmlog`. For now `npmlog` is still used for the terminal logging but with a shim in front of it to make it easier to test and use in conjunction with `proc-log`. Ref: npm/statusboard#366 This also refactors many of the tests to always use an explicit `t.testdir` for their cache since the file is opened on each `new Npm()`. Tests are also refactored to use more of `MockNpm` with behavior to add config items and load `npm` if necessary. A new fixture `mockGlobals` was also added to make much of this more ergonomic. Ref: npm/statusboard#410 Closes npm/statusboard#411 Closes npm/statusboard#367
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Make our handling of debug logs more efficient.
Related to: #366
logevents.npm.config.get('logs-max')most recent.This should not be a part of npmlog. In fact, it can be just a pretty short module in the npm
lib/utilsfolder, once everything is using proc-log instead of calling npmlog directly.The text was updated successfully, but these errors were encountered: