Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v7(tests): profile #164

Closed
darcyclarke opened this issue Jul 13, 2020 · 0 comments · Fixed by npm/cli#2373
Closed

v7(tests): profile #164

darcyclarke opened this issue Jul 13, 2020 · 0 comments · Fixed by npm/cli#2373
Assignees
@ruyadorno
Milestone
OSS - Sprint 21

Comments

@darcyclarke
Copy link
Contributor

No description provided.

@darcyclarke darcyclarke added this to the OSS - Sprint 11 milestone Jul 13, 2020
@ruyadorno ruyadorno self-assigned this Dec 11, 2020
ruyadorno added a commit to ruyadorno/cli that referenced this issue Dec 16, 2020
@ruyadorno
fix: npm profile refactor
14cc186 
- Fixes using `--otp` config option in `npm profile enable-2fa`
- Prevents trying to enable 2fa if no user is logged in
- Add `test/lib/profile.js` tests
- Async/await `lib/profile.js` refactor and more

- Fixes: npm/statusboard#164
ruyadorno added a commit to ruyadorno/cli that referenced this issue Dec 17, 2020
@ruyadorno
fix: npm profile refactor
ed0f8c0 
- Fixes using `--otp` config option in `npm profile enable-2fa`
- Prevents trying to enable 2fa if no user is logged in
- Setting email should not require password
- Add `test/lib/profile.js` tests
- Async/await `lib/profile.js` refactor and more

- Fixes: npm/statusboard#164
@ruyadorno ruyadorno mentioned this issue Dec 17, 2020
Merged
isaacs pushed a commit to ruyadorno/cli that referenced this issue Dec 18, 2020
@ruyadorno @isaacs
fix: npm profile refactor
cba3341 
- Fixes using `--otp` config option in `npm profile enable-2fa`
- Prevents trying to enable 2fa if no user is logged in
- Setting email should not require password
- Add `test/lib/profile.js` tests
- Async/await `lib/profile.js` refactor and more

- Fixes: npm/statusboard#164

PR-URL: npm#2373
Credit: @ruyadorno
Close: npm#2373
Reviewed-by: @isaacs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruyadorno ruyadorno

Labels
None yet
Projects
None yet
Milestone
OSS - Sprint 21
Development

Successfully merging a pull request may close this issue.

fix: npm profile refactor ruyadorno/cli
2 participants
@ruyadorno @darcyclarke