Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update npm ls to use Arborist #103

Closed
darcyclarke opened this issue Jun 1, 2020 · 2 comments
Closed

Update npm ls to use Arborist #103

darcyclarke opened this issue Jun 1, 2020 · 2 comments
Assignees
@ruyadorno
Milestone
OSS - Sprint 11

Comments

@darcyclarke
Copy link
Contributor

  • investigate how npm fund was migrated
  • implement the current behavior of npm v6
@darcyclarke darcyclarke added this to the OSS - Sprint 8 milestone Jun 1, 2020
@ruyadorno
Copy link

Backed from the work on this until we can figure out in a more fundamental level how to move forward with breaking changes in v7, made the effort of documenting the surface of arguments/features of npm ls in particular: https://github.com/npm/cli/blob/848d959b1c5512a3b2f8f25fe6aa3c3a1cfe3879/notes/lib/ls.md

ruyadorno added a commit to npm/cli that referenced this issue Jul 21, 2020
@ruyadorno
BREAKING: rewrite npm ls
212f13c 
- Rewrites lib/ls.js command to use @npmcli/arborist
- Updates unit tests
- Breaking changes:
  - added error codes: ELSPROBLEMS, EJSONPARSE to callback errors
  - extraneous deps depth will match current location in nm folder
  - mark top-level deps as extraneous when missing root package.json
  - don't mark deps as extraneous if they're valid deps of invalid deps
  - peer deps are now listed as regular deps, removed oddities such as
  peerinvalid label and stops labeling peer deps extraneous
  - might print diff git resolved values,
  see: https://github.com/npm/hosted-git-info
  - Parseable (--parseable) output:
    - possible order of printed elements changed
    - fixed consistency problems in which it would print root folder
    name if using a filter argument that could not match against
    any of the deps in the current installed tree
    - fixed printing non-existing paths for missing dependencies
    - fixed undefined symlink output when using --long output
  - JSON (--json) output:
    - removed: `from` property from --json output
    - removed: "[Circular]" references
    - added "missing" to list of peer-dep problems listed
    - added peerDependencies ref when using --long output
    - removed readme properties using --long output
    - Renamed error msg:
    `Failed to parse json` -> `Failed to parse root package.json`

refs:
  - npm/statusboard#99
  - npm/statusboard#103
ruyadorno added a commit to npm/cli that referenced this issue Jul 21, 2020
@ruyadorno
BREAKING: rewrite npm ls
433c5e5 
- Rewrites lib/ls.js command to use @npmcli/arborist
- Updates unit tests
- Breaking changes:
  - added error codes: ELSPROBLEMS, EJSONPARSE to callback errors
  - extraneous deps depth will match current location in nm folder
  - mark top-level deps as extraneous when missing root package.json
  - don't mark deps as extraneous if they're valid deps of invalid deps
  - peer deps are now listed as regular deps, removed oddities such as
  peerinvalid label and stops labeling peer deps extraneous
  - might print diff git resolved values,
  see: https://github.com/npm/hosted-git-info
  - Parseable (--parseable) output:
    - possible order of printed elements changed
    - fixed consistency problems in which it would print root folder
    name if using a filter argument that could not match against
    any of the deps in the current installed tree
    - fixed printing non-existing paths for missing dependencies
    - fixed undefined symlink output when using --long output
  - JSON (--json) output:
    - removed: `from` property from --json output
    - removed: "[Circular]" references
    - added "missing" to list of peer-dep problems listed
    - added peerDependencies ref when using --long output
    - removed readme properties using --long output
    - Renamed error msg:
    `Failed to parse json` -> `Failed to parse root package.json`

refs:
  - npm/statusboard#99
  - npm/statusboard#103
@darcyclarke
Copy link
Contributor Author

Update: This work was completed via the following PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ruyadorno ruyadorno

Labels
None yet
Projects
None yet
Milestone
OSS - Sprint 11
Development

No branches or pull requests
2 participants
@ruyadorno @darcyclarke