Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make prepare and normalize have feature parity with legacy packages #36

Merged
merged 2 commits into from
Jun 6, 2023

Commits on Jun 2, 2023

  1. fix: make prepare and normalize have feature parity with legacy p…

    …ackages
    
    Due to npm/cli#6470, I added `read-package-json` and
    `read-package-json-fast` to this repo as dev deps to run the new tests
    from #31 against those packages. I found a few discrepancies which I
    fixed in this PR.
    
    Full list of changes are as follows:
    
    **`normalize` / `read-package-json-fast`**
    - convert `bundleDependencies: false` to `[]`
    
    **`prepare` / `read-package-json`**
    - ignore `directories.bin` if `bin` is present
    - walk up filesystem to look for git directory
    - log a warning for inaccessible bin entries but dont delete
    
    These changes will be tracked in npm/statusboard#487 to see if they
    should be made as breaking changes with npm 10.
    
    These legacy tests can be removed once we have decided to make these
    breaking changes.
    
    Ref: npm/cli#6470
    Fixes: #35
    lukekarrys committed Jun 2, 2023
    Configuration menu
    Copy the full SHA
    075b90d View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2023

  1. Configuration menu
    Copy the full SHA
    1ea9b52 View commit details
    Browse the repository at this point in the history