Limit maxSockets for client connections #130
Conversation
misterbyrne
force-pushed
the
use-connection-pool
branch
2 times, most recently
from
d7b8fd5 to
58dab93
Compare
| @@ -39,6 +39,7 @@ function RegClient (config) { | |||
| if (typeof this.config.retry.factor !== 'number') this.config.retry.factor = 10 | |||
| if (typeof this.config.retry.minTimeout !== 'number') this.config.retry.minTimeout = 10000 | |||
| if (typeof this.config.retry.maxTimeout !== 'number') this.config.retry.maxTimeout = 60000 | |||
| if (typeof this.config.maxSockets !== 'number') this.config.maxSockets = 50 | |||
There was a problem hiding this comment.
The number 50 is pretty arbitrary but seemed to perform okay. Maybe the default should be lower or higher though. I've tried a few different values with a big shrinkwrap install and it didn't seem to make much difference past 20.
There was a problem hiding this comment.
Yeah, I expect we'll want the npm side of this patch to pass through a value and to have a default there too, since this is the sort of thing where the best value is likely heavily impacted by network conditions.
misterbyrne
force-pushed
the
use-connection-pool
branch
from
58dab93 to
1d1de0a
Compare
|
Update: after more tests - this time with Also, PR for the |
misterbyrne
force-pushed
the
use-connection-pool
branch
from
1d1de0a to
26d9081
Compare
misterbyrne
changed the title
PR-URL: #130 Credit: @misterbyrne Reviewed-By: @iarna
|
Looks great! Landed as 3aeca7a and published in v7.1.0 |
NPM installs are failing all the time for installs of large shrinkwrapped projects on my home (wifi) network. It tends to work on a wired network. I figured out that this was due to the large number of connections that npm makes to the registry. Inflating a shrinkwrap results in a request being made to the registry for each item in the dependency tree - and because of npm3's flat file structure, almost all of them happen at once.
This PR makes use of
request'sthe agent'spooloption, along withmaxSocketsoption to use client connection pooling which drastically reduces the number of outgoing connections, resulting in a quicker and more stable install.It looks like this should fix some issues people are having with installing lots of dependencies over consumer network hardware / crappy internet connections / environments with limited resources.