This repository has been archived by the owner on Aug 11, 2021. It is now read-only.
Report in http header if we're in CI #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iarna
force-pushed
the
ci-header
branch
2 times, most recently
from
f01d0f6
to
8adacae
Compare
othiym23
approved these changes
Sep 23, 2016
| @@ -11,6 +11,9 @@ function initialize (uri, method, accept, headers) { | |||
| this.config.sessionToken = crypto.randomBytes(8).toString('hex') | |||
| this.log.verbose('request id', this.config.sessionToken) | |||
| } | |||
| if (this.config.isFromCI == null) { | |||
| this.config.isFromCI = Boolean(process.env['CI'] === 'true' || process.env['TDDIUM'] || process.env['JENKINS_URL'] || process.env['bamboo.buildKey']) | |||
There was a problem hiding this comment.
This line is too long, unlike this comment. Wrap?
iarna
added a commit
to npm/npm
that referenced
this pull request
Oct 20, 2016
Credit: @iarna PR-URL: npm/npm-registry-client#129 PR-URL: npm/npm-registry-client#145
iarna
added a commit
to npm/npm
that referenced
this pull request
Oct 20, 2016
Credit: @iarna PR-URL: npm/npm-registry-client#129 PR-URL: npm/npm-registry-client#145
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per a lunch conversation with @ceejbot, this adds an
npm-in-ciheader to requests that istrueorfalsebased on the following environment checks:CI="true": Travis, CircleCI, Gitlab CI, Snap CI, Codeship, semaphore, drone.io, Buildkite, PlatformIOJENKINS_URLis set: Jenkinsbamboo.buildKeyis set: BambooTDDIUMis set: Solano