Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm happily creates packages that won't unpack on windows #9

Closed
chriseppstein opened this issue Feb 28, 2018 · 2 comments
Closed

npm happily creates packages that won't unpack on windows #9

chriseppstein opened this issue Feb 28, 2018 · 2 comments

Comments

@chriseppstein
Copy link

chriseppstein commented Feb 28, 2018 •
edited
Loading

I got this bug recently: mahirshah/css-property-parser#21 because a filename had an asterisk in it. Evidently windows gets mad about that. I worked around the issue by renaming the files, but it seemed like the sort of thing that npm might want to raise an error about or handle somehow so that it's not an error.
@isaacs
Copy link
Contributor

isaacs commented Feb 28, 2018

Note: There may be a way to escape these characters in node tar, like we do for : and <.

@isaacs isaacs mentioned this issue Oct 10, 2018
Closed
@isaacs
Copy link
Contributor

isaacs commented Jun 4, 2019

There does not appear to be a way to make this work at the tar level.

I think the answer here is just to disallow them in npm-packlist (like how we disallow symlinks), since it's really about application portability.

isaacs added a commit that referenced this issue Jun 4, 2019
@isaacs
Omit filenames containing asterisks
01c90ed 
Filenames containing * chars break windows and create incompatible
archives in the npm registry.

In the next major release, this should raise an error instead of
silently omitting them, so that authors can be alerted.

Fix #9
@isaacs isaacs mentioned this issue Jun 4, 2019
Closed
isaacs added a commit that referenced this issue Oct 9, 2019
@isaacs
Omit filenames containing asterisks
cd86177 
Filenames containing * chars break windows and create incompatible
archives in the npm registry.

In the next major release, this should raise an error instead of
silently omitting them, so that authors can be alerted.

Fix #9
@isaacs isaacs closed this as completed in 6655e3c Oct 9, 2019
@DanielRuf DanielRuf mentioned this issue Oct 2, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Omit filenames containing asterisks npm/npm-packlist
2 participants
@chriseppstein @isaacs