Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MinVersion failing for '^2.16.2 ^2.16' alike range #341

Closed
wants to merge 1 commit into from
Closed

MinVersion failing for '^2.16.2 ^2.16' alike range #341

wants to merge 1 commit into from

Conversation

alfredsgenkins
Copy link
Contributor

It seems like the logic was incorrect, after switching the order of comparatement, the minVersion started to return proper results.

References

Fixes #340
Closes #340

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e2d11bf on alfredsgenkins:patch-1 into 6088070 on npm:master.

@isaacs isaacs closed this in 2d01126 Dec 1, 2020
This was referenced Apr 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] minVersion returns null for valid ranges
2 participants
@alfredsgenkins @coveralls