fix: recursive directory ignore rules #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Citing from the gitignore docs [1]: > If there is a separator at the beginning or middle (or both) of the > pattern, then the pattern is relative to the directory level of the > particular .gitignore file itself. Otherwise the pattern may also > match at any level below the .gitignore level. Previously, parent walkers were only passed the resolved path to a file entry via filterEntry(). This patch also passes the entry's basename which is matched against the rule if it is relative. Regression tests are included as well. Closes #9. [1] http://git-scm.com/docs/gitignore#_pattern_format#:~:text=If%20there%20is%20a%20separator%20at%20the%20beginning%20or%20middle%20(or%20both)%20of%20the%20pattern%2C%20then%20the%20pattern%20is%20relative%20to%20the%20directory%20level%20of%20the%20particular%20.gitignore%20file%20itself.%20Otherwise%20the%20pattern%20may%20also%20match%20at%20any%20level%20below%20the%20.gitignore%20level.
Merged
lukekarrys
approved these changes
Nov 28, 2023
wraithgar
added a commit
that referenced
this pull request
Nov 29, 2023
Gets us closer to parity w/ the gitignore rules. Citing from the [gitignore docs](http://git-scm.com/docs/gitignore#_pattern_format#:~:text=If%20there%20is%20a%20separator%20at%20the%20beginning%20or%20middle%20(or%20both)%20of%20the%20pattern%2C%20then%20the%20pattern%20is%20relative%20to%20the%20directory%20level%20of%20the%20particular%20.gitignore%20file%20itself.%20Otherwise%20the%20pattern%20may%20also%20match%20at%20any%20level%20below%20the%20.gitignore%20level.): > If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular `.gitignore` file itself. Otherwise the pattern may also match at any level below the `.gitignore` level. Previously, parent walkers were only passed the resolved path to a file entry via filterEntry()`. This patch also passes the entry's basename which is matched against the rule if it is relative. Regression tests are included as well. Closes #9. --------- Co-authored-by: Christoph Thiede <[email protected]>
wraithgar
added a commit
that referenced
this pull request
Nov 29, 2023
Gets us closer to parity w/ the gitignore rules. Closes #9. --------- Co-authored-by: Christoph Thiede <[email protected]>
Open
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a rebase and cleanup of #16
Citing from the gitignore docs:
Previously, parent walkers were only passed the resolved path to a file
entry via filterEntry()`. This patch also passes the entry's basename
which is matched against the rule if it is relative.
Regression tests are included as well.
Closes #9.