Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tag heading levels properly #1374

Merged
merged 5 commits into from
Dec 2, 2024
Merged

Conversation

kartykp
Copy link
Contributor

@kartykp kartykp commented Nov 14, 2024

This pull request includes updates to the heading levels in the table of contents and MDX components to ensure consistency and improve accessibility.

Changes to heading levels:

  • src/components/table-of-contents.js: Changed the heading level from h3 to h2 for the "Table of contents" heading to improve accessibility and consistency.
  • src/mdx/components.js: Updated the heading levels in the Headings component to ensure that H3 wraps h2, H4 wraps h3, H5 wraps h4, and H6 wraps h5 to maintain a proper heading hierarchy.

@kartykp kartykp self-assigned this Nov 14, 2024
@kartykp kartykp marked this pull request as draft November 14, 2024 22:20
@kartykp kartykp changed the title Bug fix for #9219 & #9186 Bug fix for #9219 Nov 25, 2024
This reverts commit ec7fab8.
@kartykp kartykp marked this pull request as ready for review December 2, 2024 21:08
@wraithgar wraithgar changed the title Bug fix for #9219 fix: tag heading levels properly Dec 2, 2024
@wraithgar wraithgar merged commit d86169f into main Dec 2, 2024
8 of 9 checks passed
@wraithgar wraithgar deleted the kartykp/accessibility-bug-fixes branch December 2, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants