Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps updates #7737

Merged
merged 11 commits into from
Aug 21, 2024
Merged

Deps updates #7737

merged 11 commits into from
Aug 21, 2024

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar requested a review from a team as a code owner August 20, 2024 15:04
Copy link
Contributor

@hashtagchris hashtagchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was interesting to see that cacache was already patched in #7631.

@@ -136,9 +136,6 @@
!/mute-stream
!/negotiator
!/node-gyp
!/node-gyp/node_modules/
/node-gyp/node_modules/*
!/node-gyp/node_modules/proc-log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled down these changes, and confirmed this is being removed because it's now dedupped.

├─┬ [email protected]
│ └── [email protected] deduped

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that was my bad, I didn't realize they'd made the PR into the cli itself. Not my best day.

@wraithgar wraithgar merged commit ed4add1 into latest Aug 21, 2024
22 checks passed
@wraithgar wraithgar deleted the gar/deps-updates branch August 21, 2024 13:47
@github-actions github-actions bot mentioned this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants