chore: reduce windows shim test flakes #7386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/windooooooooooooooooooooooows
branch
from
22e7b69
to
d736700
Compare
lukekarrys
force-pushed
the
lk/windooooooooooooooooooooooows
branch
from
d736700
to
0e5be1a
Compare
lukekarrys
changed the title
wraithgar
reviewed
Apr 19, 2024
wraithgar
approved these changes
Apr 19, 2024
Co-authored-by: Gar <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rimraf.moveRemoveto deletenode.exesince this is the least error-prone way to make sure it doesn't throw when tap is cleaning it upshell: truewhen running spawnSyncNot merging this until I get 3 consecutive successful CI runs