Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semver link and note on empty string format to deprecate doc #68

Merged
merged 3 commits into from
Nov 26, 2018

Conversation

neverett
Copy link
Contributor

I got feedback from our support team that some users are confused about semver range formatting and the format needed for the empty string in this doc, so I've made a few small tweaks to reduce confusion.

@neverett neverett requested a review from a team as a code owner September 12, 2018 20:25
@zkat zkat added semver:patch semver patch level for changes docs labels Nov 13, 2018
Copy link
Contributor

@zkat zkat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks, @neverett!

@zkat zkat changed the base branch from latest to release-next November 13, 2018 14:55
@zkat zkat merged commit 6cc70cc into release-next Nov 26, 2018
@zkat zkat deleted the ne-semver-link branch November 26, 2018 16:24
zkat pushed a commit that referenced this pull request Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants