-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add smoke-test that will use current npm source to overwrite itself #6491
Conversation
73b28cb
to
6631377
Compare
I also ran the smoke publish tests manually to make sure the new smoke test passes there as well: https://github.com/npm/cli/actions/runs/5054056601 |
6631377
to
8bf1994
Compare
Ignore the 20 something force pushes. If checks are green, this is ready for review. |
no statistically significant performance changes detected timing results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a test that works in Windows is kind of a big deal. In the past it was Windows that manifested this error of npm not being able to update over the top of itself.
All the smoke tests, including this new one, run in Windows. It's only the smoke publish test that doesn't run in Windows due to the git dirty check failing at various points during the test. That test has never run in Windows, but is mainly to test our publish script and then ensure that the existing smoke tests still pass after a mock publish. This new test is asserting that:
|
No description provided.