Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add smoke-test that will use current npm source to overwrite itself #6491

Merged
merged 1 commit into from
May 23, 2023

Conversation

lukekarrys
Copy link
Contributor

No description provided.

@lukekarrys lukekarrys requested a review from a team as a code owner May 22, 2023 22:19
@lukekarrys lukekarrys force-pushed the lk/replace-npm-smoke-test branch 26 times, most recently from 73b28cb to 6631377 Compare May 23, 2023 06:41
@lukekarrys
Copy link
Contributor Author

I also ran the smoke publish tests manually to make sure the new smoke test passes there as well: https://github.com/npm/cli/actions/runs/5054056601

@lukekarrys
Copy link
Contributor Author

Ignore the 20 something force pushes. If checks are green, this is ready for review.

@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented May 23, 2023

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 44.162 ±8.33 17.211 ±0.32 16.730 ±0.07 19.162 ±0.52 2.704 ±0.04 2.701 ±0.00 2.286 ±0.10 11.486 ±0.03 2.223 ±0.03 3.292 ±0.03 0.358 ±0.01 0.381 ±0.00
#6491 51.443 ±0.85 17.602 ±0.01 17.195 ±0.12 19.927 ±0.84 2.711 ±0.04 2.700 ±0.01 2.238 ±0.03 11.712 ±0.13 2.269 ±0.07 3.457 ±0.05 0.368 ±0.00 0.406 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
show-version run-script
npm@9 30.122 ±2.00 13.372 ±0.02 13.014 ±0.17 13.821 ±0.65 2.372 ±0.01 2.397 ±0.03 2.246 ±0.03 8.778 ±0.05 2.071 ±0.02 2.920 ±0.00 0.365 ±0.02 0.383 ±0.01
#6491 28.278 ±3.31 13.729 ±0.07 13.281 ±0.04 13.965 ±0.18 2.413 ±0.05 2.444 ±0.01 2.289 ±0.06 8.984 ±0.02 2.145 ±0.02 3.040 ±0.04 0.370 ±0.00 0.414 ±0.00

Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a test that works in Windows is kind of a big deal. In the past it was Windows that manifested this error of npm not being able to update over the top of itself.

@lukekarrys
Copy link
Contributor Author

All the smoke tests, including this new one, run in Windows. It's only the smoke publish test that doesn't run in Windows due to the git dirty check failing at various points during the test.

That test has never run in Windows, but is mainly to test our publish script and then ensure that the existing smoke tests still pass after a mock publish.

This new test is asserting that:

  • the source controlled version of npm can pack and install itself globally
  • then that global version is able to pack and install an empty tarball without failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants