gar/libnpmexec fixes #5244
Merged
gar/libnpmexec fixes #5244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wraithgar
commented
Aug 2, 2022
wraithgar
commented
- deps: add @npmcli/[email protected]
- deps: add [email protected]
- deps: @npmcli/[email protected]
- fix: properly find locally/globally/npxCache packages
- fix: use binPaths
|
Closes #3210 |
Lots of bugfixes here, we properly parse ranges and versions, and we also now work with git repos and gists, and know when they are already installed.
This will allow for a locally installed package to differ from the one requested on the command line, the one requested will now actually run.
|
no statistically significant performance changes detected timing results
|
wraithgar
force-pushed
the
gar/libnpmexec-fixes
branch
from
0a8ee24 to
c3996ba
Compare
|
Closes #4204 |
wraithgar
force-pushed
the
gar/libnpmexec-fixes
branch
from
c3996ba to
7c1fd0b
Compare
|
Closes #3058 |
wraithgar
force-pushed
the
gar/libnpmexec-fixes
branch
3 times, most recently
from
885063e to
1d186fe
Compare
The workspace-location-msg file was being called improperly by `npm init` and not even tested, and when digging in it probably shouldn't be used at all from there. It's not always a workspace in this context.
wraithgar
force-pushed
the
gar/libnpmexec-fixes
branch
from
1d186fe to
6038528
Compare
nlf
approved these changes
Aug 2, 2022
Merged
|
@wraithgar comment converted to #5269 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.