-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add --replace-registry-host=<npmjs|always|never> #4860
Conversation
no statistically significant performance changes detected timing results
|
0bbdecb
to
0bd6d2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good, but i did see one thing that may cause an issue for some folks
0bd6d2f
to
6eb06ed
Compare
Please consider the |
@fritzy what's the state of this PR? |
6eb06ed
to
2868388
Compare
|
no statistically significant performance changes detected timing results
|
@fritzy did we investigate @everett1992's question & PR? (ie. #4264) Just want to make sure all concerns here are resolved before we add this support |
@darcyclarke yeah, this was broken up into a previous PR with his work in it. This is a separate piece. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok one last thing that needs to be tweaked then i can land this!
2868388
to
17721c6
Compare
17721c6
to
2e5dfb9
Compare
Dist references in a lockfile currently have their host replaced with the configured registry when it is https://registry.npmjs.org, but not otherwise. Between this PR and a pacote PR, we added the options or
never
replacing the host oralways
replacing the host, in addition to the current behavior ofnpmjs
.