Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package unpublished and 404 cleanup #4572

Merged
merged 2 commits into from
Mar 17, 2022
Merged

package unpublished and 404 cleanup #4572

merged 2 commits into from
Mar 17, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 16, 2022

Two commits here, one removes the user name from the unpublished message, as that's no longer returned by the npm registry. The second one removes the "bug the author" message from the package 404, that copy is outdated and from a different era.

@wraithgar
Copy link
Member Author

Going to also add a commit removing the "bug the author" message on a 404.

@ljharb
Copy link
Contributor

ljharb commented Mar 16, 2022

That seems like a registry change that would break older and current clients; can the registry send that value even if modern npm isn’t using it?

@wraithgar wraithgar changed the title fix: remove name from unpublished message package unpublished and 404 cleanup Mar 16, 2022
@ljharb
Copy link
Contributor

ljharb commented Mar 16, 2022

Seeing a related PR, how is it a privacy concern to tell me my own name?

@wraithgar
Copy link
Member Author

The registry doesn't send that anymore, so this cleans the message up. Having the npm registry send dummy data there for old clients would be something you can request via https://www.npmjs.com/support

@ljharb
Copy link
Contributor

ljharb commented Mar 16, 2022

Right, but why did the registry stop sending that info? and when was that breaking change announced?

@wraithgar wraithgar force-pushed the gar/unpublished-undefined branch from 478cc81 to 62e21c8 Compare March 16, 2022 16:32
@npm-robot
Copy link
Contributor

npm-robot commented Mar 16, 2022

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 53.199 ±4.36 29.920 ±0.60 28.275 ±15.92 19.427 ±0.72 3.064 ±0.12 2.930 ±0.04 2.393 ±0.06 11.492 ±0.24 2.364 ±0.04 3.470 ±0.07
#4572 52.215 ±6.84 29.387 ±0.14 31.014 ±19.38 19.841 ±0.83 3.017 ±0.19 2.978 ±0.05 2.316 ±0.02 11.347 ±0.19 2.295 ±0.01 3.663 ±0.45
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 36.286 ±0.33 22.467 ±0.09 12.883 ±0.29 13.784 ±0.03 2.636 ±0.08 2.720 ±0.04 2.299 ±0.07 8.376 ±0.13 2.176 ±0.01 3.047 ±0.11
#4572 38.159 ±1.87 23.324 ±0.15 12.757 ±0.07 13.628 ±0.09 2.621 ±0.01 2.633 ±0.04 2.335 ±0.03 8.474 ±0.15 2.255 ±0.02 2.943 ±0.04

@nlf nlf merged commit f7e58fa into latest Mar 17, 2022
@nlf nlf deleted the gar/unpublished-undefined branch March 17, 2022 17:57
@nlf nlf mentioned this pull request Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants