Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps/fetch #4393

Merged
merged 2 commits into from
Feb 9, 2022
Merged

deps/fetch #4393

merged 2 commits into from
Feb 9, 2022

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar requested a review from a team as a code owner February 9, 2022 17:10
@wraithgar
Copy link
Member Author

lru-cache 7 will dedupe again as we get the other deps moved over to it.

@wraithgar wraithgar merged commit ab92699 into release-next Feb 9, 2022
@wraithgar wraithgar deleted the deps/fetch branch February 9, 2022 17:19
@npm-robot
Copy link
Contributor

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 62.597 ±9.05 36.889 ±0.12 23.040 ±0.03 26.256 ±1.73 3.708 ±0.02 3.711 ±0.08 3.012 ±0.08 14.900 ±0.13 2.946 ±0.05 4.299 ±0.02
#4393 0.502 ±0.02 0.499 ±0.02 0.482 ±0.00 0.481 ±0.00 0.484 ±0.00 0.479 ±0.00 0.484 ±0.01 0.483 ±0.00 0.481 ±0.01 0.485 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 47.729 ±4.29 27.830 ±0.20 16.663 ±0.01 17.606 ±0.03 3.371 ±0.02 3.338 ±0.02 2.923 ±0.04 10.917 ±0.04 2.829 ±0.01 3.712 ±0.04
#4393 0.499 ±0.01 0.489 ±0.01 0.483 ±0.00 0.509 ±0.02 0.493 ±0.01 0.485 ±0.00 0.484 ±0.00 0.490 ±0.01 0.483 ±0.00 0.501 ±0.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants