Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(log): pass in logger to more external modules #4386

Merged
merged 1 commit into from
Feb 8, 2022
Merged

fix(log): pass in logger to more external modules #4386

merged 1 commit into from
Feb 8, 2022

Conversation

wraithgar
Copy link
Member

We missed two commands in the last PR. This should complete the task

@wraithgar
fix(log): pass in logger to more external modules
69818a9 
We missed two commands in the last PR. This should complete the task
@wraithgar wraithgar requested a review from a team as a code owner February 8, 2022 15:33
ruyadorno
ruyadorno approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@ruyadorno ruyadorno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@wraithgar wraithgar merged commit fb6e2dd into release-next Feb 8, 2022
@wraithgar wraithgar deleted the gar/log-to-more-commands branch February 8, 2022 16:44
@nlf nlf mentioned this pull request Feb 10, 2022
Merged
@npm-robot npm-robot mentioned this pull request Feb 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruyadorno ruyadorno ruyadorno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wraithgar @ruyadorno