Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove some pruned deps #4151

Merged
merged 1 commit into from
Jan 4, 2022
Merged

chore: remove some pruned deps #4151

merged 1 commit into from
Jan 4, 2022

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Dec 9, 2021

looks like these should've been removed in the last release but got left behind unnecessarily

@nlf nlf requested a review from a team as a code owner December 9, 2021 21:24
@npm-robot
Copy link
Contributor

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 44.238 ±0.63 30.189 ±0.13 17.491 ±0.17 19.901 ±0.79 2.850 ±0.06 2.846 ±0.01 2.287 ±0.02 11.491 ±0.09 2.295 ±0.01 2.977 ±0.04
#4151 44.733 ±0.50 30.281 ±0.60 17.311 ±0.03 19.962 ±0.96 2.878 ±0.05 2.868 ±0.00 2.263 ±0.04 11.390 ±0.06 2.283 ±0.01 2.988 ±0.01
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 33.696 ±0.64 23.303 ±0.04 12.671 ±0.12 13.800 ±0.58 2.527 ±0.02 2.569 ±0.00 2.288 ±0.05 8.355 ±0.03 2.138 ±0.03 2.766 ±0.12
#4151 33.827 ±0.15 23.275 ±0.21 13.242 ±0.21 13.995 ±0.09 2.571 ±0.01 2.592 ±0.03 2.297 ±0.01 8.522 ±0.02 2.201 ±0.02 2.695 ±0.02

@wraithgar wraithgar merged commit 59b8354 into release-next Jan 4, 2022
@wraithgar wraithgar deleted the nlf/prune-deps branch January 4, 2022 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants