Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in save-peer description #4072

Merged
merged 1 commit into from
Nov 22, 2021
Merged

docs: fix typo in save-peer description #4072

merged 1 commit into from
Nov 22, 2021

Conversation

chalkygames123
Copy link
Contributor

@chalkygames123 chalkygames123 commented Nov 21, 2021

Corrected the typo and then ran TAP_SNAPSHOT=1 npm test.

@chalkygames123 chalkygames123 requested a review from a team as a code owner November 21, 2021 15:22
@wraithgar wraithgar changed the base branch from latest to release-next November 22, 2021 14:59
@@ -82,7 +82,7 @@ dist
dist-tags:
latest: 1.0.0

published yesterday
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why this changed ended up in your tests but it's making CI fail. Likely just need to revert this one to matchrelease-next, and it's something for us to look into.

@wraithgar
Copy link
Member

Try running npm run snap instead, there's a postsnap hook that runs that rebuilds additional files that are dependent on these config definitions.

@chalkygames123
Copy link
Contributor Author

Okay, I'll do. Thanks for your instruction :)

@chalkygames123
Copy link
Contributor Author

Hmm, while the changes now include config.md, CI still fails. Should I only commit the change in definitions.js for now?

@wraithgar
Copy link
Member

I think if you omit the changes in tap-snapshots/test/lib/commands/view.js.test.cjs you should be ok. If not we'll just call it ok and I'll fix it when I merge it and make sure it's passing.

@chalkygames123
Copy link
Contributor Author

Now it looks ok!

@wraithgar
Copy link
Member

Thanks for sticking with it, I know these tests are tricky to get passing but they save us a lot of headache down the line when it comes to cutting our releases.

@wraithgar wraithgar merged commit fc46a79 into npm:release-next Nov 22, 2021
@wraithgar wraithgar mentioned this pull request Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants