Release/v7.15.1 #3340
Merged
Release/v7.15.1 #3340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
force-pushed
the
release/v7.15.1
branch
from
0bd063a to
b61cc1b
Compare
The npm output function refers to this.log. libnpmexec has that passed in, which decoupled the function from the npm object. This fixes it, and sets the tests up in a way where if the output function ever becomes detached from this.npm in the same way, tests will fail. PR-URL: #3329 Credit: @wraithgar Close: #3329 Reviewed-by: @ruyadorno
renames read-local-package to read-package-name The global check needed to be moved outside this function, because it was handled differently (and will be even moreso when we implement diff workspaces) in each function. This allowed us to now pass in the prefix itself instead of the npm object, so we can reuse this function to look up package names when we refactor npm diff for workspaces. PR-URL: #3331 Credit: @wraithgar Close: #3331 Reviewed-by: @ruyadorno
ruyadorno
force-pushed
the
release/v7.15.1
branch
from
b61cc1b to
06d7ba4
Compare
ruyadorno
force-pushed
the
release/v7.15.1
branch
from
06d7ba4 to
73633e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v7.15.1 (2021-05-31)
BUG FIXES
2fb189c08#3329 fix(libnpmexec): don't detach output from npm (@wraithgar)DEPENDENCIES
1290ea31c@npmcli/[email protected]e06f16761[email protected]