fix(diff): set option "where" for pacote #2822
Merged
+7
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
added
Release 7.x
ruyadorno
changed the title
wraithgar
approved these changes
Mar 4, 2021
pacote expects a **where** option that sets the cwd for all its operations, ref: https://github.com/npm/pacote#options This change properly sets that option in libnpmdiff options that will then properly forward it to pacote, this is specially important for when reading local file system specs. PR-URL: npm#2822 Credit: @ruyadorno Close: npm#2822 Reviewed-by: @wraithgar
ruyadorno
force-pushed
the
diff-set-where-pacote-option
branch
from
b674c71
to
b3e7dd1
Compare
This was referenced Mar 4, 2021
Merged
This was referenced Mar 5, 2021
This was referenced Mar 12, 2021
This was referenced Mar 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pacote expects a where option that sets the cwd for all its
operations, ref: https://github.com/npm/pacote#options
This change properly sets that option in libnpmdiff options that will
then properly forward it to pacote, this is specially important for when
reading local file system specs.