Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ARM64 platform check #195

Closed
wants to merge 1 commit into from
Closed

Conversation

ossdev07
Copy link
Contributor

@ossdev07 ossdev07 commented May 1, 2019

I have added the arm64 architecture check in the legacy-platform-all.js test file.

@ossdev07 ossdev07 requested a review from a team as a code owner May 1, 2019 05:38
@ossdev07
Copy link
Contributor Author

Ping @luislobo @aeschright

Please, could you look into PR and suggest if anything else is required from my side.

@rhenwood-arm
Copy link

I would be nice for me (as an AArch64 aka Arm64 user) if this small fix was landed. Is there any feedback?

@ossdev07
Copy link
Contributor Author

Hi, @luislobo @aeschright

Is there any update on the PR status?

@aeschright
Copy link
Contributor

Unfortunately, I'm no longer on the project and don't know when PRs will be merged again. Details: https://gist.github.com/aeschright/8ed09cbc2a4aee00fcb4ad35086d76a6

@ossdev07
Copy link
Contributor Author

@aeschright Thanks for letting us know.

@isaacs isaacs added the semver:patch semver patch level for changes label Jun 26, 2019
@DanielRuf
Copy link

Is this already merged?

@ossdev07
Copy link
Contributor Author

ossdev07 commented Jul 9, 2019

Thanks for accepting the PR, it got merged by the raised PR #205

@ossdev07 ossdev07 closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch semver patch level for changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants