-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check run script existence with undefined #139
Conversation
Did this come from a discussion you can point me to? Or can you describe the underlying use case it would solve? |
82170b4
to
db63b89
Compare
I was running one of my projects through some automated build tools which needed specific npm scripts to exist. In this project, there was no need for that script to run so I created an empty npm script, hoping it would solve the problem. But then I got the error message shown above. I could not find any discussion about this situation and the change was rather small, so I went straight to PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a reasonable allowance -- but I can't really review the changes you made, because this needs to be rebased onto latest
. See how "Files changed" says 938
🙃 .
Rebased :) |
Hi @zkat , is there anything else I can do? PR is rebased now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good now! Thanks a bunch. :)
Makes it possible to run empty script instead of outputting slightly confusing error message.
In
package.json
:Before
After