Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove docs/package-lock.json #4344

Closed
thernstig opened this issue Jan 28, 2022 · 1 comment
Closed

chore: Remove docs/package-lock.json #4344

thernstig opened this issue Jan 28, 2022 · 1 comment
Labels
Priority 0 will get attention right away

Comments

@thernstig
Copy link

I learned that a workspace-aware project should only retain a package-lock.json file at the root of the repository, see comment at #1984 (comment)

The docs/ directory in this repository is a workspace:

cli/package.json

Lines 5 to 8 in f5a7360

"workspaces": [
"docs",
"workspaces/*"
],

Should https://github.com/npm/cli/blob/latest/docs/package-lock.json thus be removed?

@darcyclarke darcyclarke changed the title Remove docs/package-lock.json [Question] Remove docs/package-lock.json Jan 28, 2022
@darcyclarke darcyclarke added chore Priority 0 will get attention right away labels Jan 28, 2022
@darcyclarke darcyclarke changed the title [Question] Remove docs/package-lock.json chore: Remove docs/package-lock.json Jan 28, 2022
@ruyadorno
Copy link
Contributor

good catch! thanks @thernstig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 0 will get attention right away
Projects
None yet
Development

No branches or pull requests

3 participants