[BUG] Unable to resolve peer dependency if version contains ">=" #2120

RobinWijnant · 2020-11-04T11:24:01Z

Current Behavior:

When resolving a peer dependency that has a ">=" in it's version, npm uses the latest version of that package to compare with the current dependency version in the package.json.

In this case: npm is looking for react 17, while react 16.13 is also a version that is suits >=16.9.0

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   react@"^16.13.1" from the root project
npm ERR!   peer react@">=16.9.0" from @testing-library/[email protected]
npm ERR!   node_modules/@testing-library/react-hooks
npm ERR!     @testing-library/react-hooks@"3.4.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17.0.1" from [email protected]
npm ERR! node_modules/react-test-renderer
npm ERR!   peer react-test-renderer@">=16.9.0" from @testing-library/[email protected]
npm ERR!   node_modules/@testing-library/react-hooks
npm ERR!     @testing-library/react-hooks@"3.4.1" from the root project
npm ERR!

Expected Behavior:

npm should be able to resolve the [email protected] peer dependency from @testing-library/[email protected] because [email protected] is a dependency that matches react@>=16.9.0.

Steps To Reproduce:

mkdir test-peers
npm init
npm install [email protected]
npm install @testing-library/[email protected]

Environment:

OS: Mac OS 10.15.7
Node: 12.14.1
npm: 7.0.8

The text was updated successfully, but these errors were encountered:

RobinWijnant · 2020-11-04T11:34:32Z

I have to downgrade @testing-library/[email protected] because the peer react-test-renderer@">=16.9.0" will resolve in react-test-renderer@">=17.0.1". This version of react-test-renderer needs in turn react@"17.0.1"

ljharb · 2020-11-04T17:30:42Z

@RobinWijnant you shouldn't need to do that; but you will need to manually specify react-test-renderer@16 as a dev dep.

isaacs · 2020-11-06T17:27:07Z

Hmm.... yeah, so the react-test-renderer@">=16.9.0" peer dep resolves to [email protected], which requires react@17, and because @testing-library/react-hooks@3 requires react-test-renderer@>=16.9.0, it resolves to that higher version.

We do aggressively dedupe peerDeps, so if something else were pulling in a lower version of react-test-renderer, we'd use that instead of 17, but what we don't do is roll back to an earlier version if it ends up bringing in a peer later down the line.

Eg:

a -> PEER(b@>=1)
b@1 -> PEER(c@>=1)
b@2 -> PEER(c@>=2)
c@1 -> PEER(d@>=1)
c@2 -> PEER(d@>=2)
thing -> (a, d@1) <-- this will cause troubles, because a->b@2->c@2->d@2 conflicts with d@1

The only way to resolve this would likely be to build up a full pubgrub style ruleset. We sort of approximate such a thing today, but rely on heuristics and nesting to get out of some of the stickiest situations.

This also highlights the problem with using >= rather than ^. We might be able to skirt around the worst hazards by preferring a >= match which is also within the ^ range, where possible. In that case, the >=16.9.0 would resolve to the same as ^16.9.0, but be able to dedupe against 17.0.1 if necessary.

Either of these ideas probably merit an RFC though.

isaacs · 2020-11-13T17:35:31Z

Actually, just preferring a ^ match when >= is used won't do it. Too many packages out there have peer dependencies like webpack@^4.1.0 || ^5.0.3, and catching every possible iteration won't work out. Eventually, we're always going to have NP-hard territory to venture into.

csvan · 2020-11-15T08:27:14Z

I don't believe this should be closed. It currently breaks standard NPM7 installs of several major dependencies, such as for example styled-components:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: @[email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react
npm ERR!   dev react@"^16.8.0" from the root project
npm ERR!   peer react@">= 16.8.0" from [email protected]
npm ERR!   node_modules/styled-components
npm ERR!     dev styled-components@"^5.0.0" from the root project
npm ERR!     peer styled-components@">= 5" from [email protected]
npm ERR!     node_modules/jest-styled-components
npm ERR!       jest-styled-components@"^7.0.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer react@"17.0.1" from [email protected]
npm ERR! node_modules/react-dom
npm ERR!   peer react-dom@">= 16.8.0" from [email protected]
npm ERR!   node_modules/styled-components
npm ERR!     dev styled-components@"^5.0.0" from the root project
npm ERR!     1 more (jest-styled-components)
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR! 
npm ERR! See /Users/csvanefalk/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/csvanefalk/.npm/_logs/2020-11-15T08_19_37_425Z-debug.log

I understand that the solution is complex (and I have nothing to contribute myself), but until one is in place it is probably useful to keep this (or a similar) issue open as a reference point for people running into it.

On that note, the above is temporarily resolvable by passing the --legacy-peer-deps flag.

ljharb · 2020-11-15T17:03:42Z

Seems like you’re missing a top-level dependency on react-dom (that matches the same minor as react itself). If you fix that, what happens?

csvan · 2020-11-15T18:53:23Z

@ljharb yes, it works if I add explicit dependencies at the top level like in npm6, but my understanding was that npm7 resolves and installs peer dependencies in a way that meant this was no longer necessary, sorry if I got this wrong: https://github.com/npm/rfcs/blob/latest/implemented/0025-install-peer-deps.md

The problem seems to be that since the peer version of react-dom in this case is >= 16.8.0 (this is true for all my dependencies and sub-dependencies, none of them have a peer dependency on React 15 or 17), npm7 resolves the latest available version (17.0.1 in this case), but then concludes that it is not a match for the peer dependency.

ljharb · 2020-11-15T19:02:14Z

It’s sometimes no longer necessary, but it’s still always better to be explicit.

abaidbutt · 2020-12-10T06:26:12Z

please use the LTS version of node it help me a lot to save my life in peer dependencies tree errors
when install a dependency with npm in react-native it give me this error my issue resolve using LTS version of Node.

csvan · 2020-12-10T08:57:58Z

please use the LTS version of node it help me a lot to save my life in peer dependencies tree errors
when install a dependency with npm in react-native it give me this error my issue resolve using LTS version of Node.

You can get the same behavior in npm7 by passing the --legacy-peer-deps flag for now

jaquinocode · 2021-03-16T09:54:17Z

For anyone coming from a web search, in this thread ljharb suggested installing an older version of react-test-renderer that's actually compatible w/ the issue creator's project's version of react by installing react-test-renderer@16 as a dev dep. So basically, you should run this command:

npm i react-test-renderer@SOME_VERSION --save-dev where SOME_VERSION is the general version of react that you're using in your project.

For instance, in my project I have react version 16.13.1 installed as listed on my package.json. So for me the command would be:

npm i [email protected] --save-dev

For me that fixed my issue with installing react-test-renderer & I was able to properly install it.

Edit: you might want to also edit the semantic version for react-test-renderer in your package.json so that's its a fixed version (e.g. "^16.13.1" => "16.13.1"). So that way the exact version you want always gets installed. Or better yet, use a ~ like ~16.13.1, which at least allows for minor patches.

ljharb · 2021-03-16T13:52:45Z

You don't need it to be a fixed version; the ^ will still work because it won't install v17, and using it is a best practice.

jaquinocode · 2021-03-16T14:01:06Z

With the ^, version 16.14 for the test renderer would install which requires 16.14 for React. I'm using 16.13.1 for React. So then it would give an error. So I got rid of the ^ to fix it.

ljharb · 2021-03-16T14:27:26Z

Fair enough - with react, you probably want to use ~ so that the minors are pinned.

jaquinocode · 2021-03-16T20:09:06Z

Ah, thanks I forgot about that good idea.

…

On Tue, Mar 16, 2021, 7:27 AM Jordan Harband ***@***.***> wrote: Fair enough - with react, you probably want to use ~ so that the minors are pinned. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#2120 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AGXXPQ3THXJMGTMS3PQTCVDTD5TGLANCNFSM4TJ5WXZA> .

mauricioross · 2023-01-14T03:03:40Z

Hi everyone, I have the same problem, I must upgrade the proyect to latest version of NxMonorepo, in this project have a app with next js and react, then next js and react also upgrade:

latest version are:

"dependencies": {
"@nrwl/next": "15.4.3-beta.2",
"@types/ineum": "187.0.1",
"core-js": "3.26.1",
"crypto-js": "4.1.1",
"express": "4.18.2",
"hash.js": "1.1.7",
"js-cookie": "^3.0.1",
"jsencrypt": "3.3.1",
"next": "13.0.0",
"next-seo": "4.29.0",
"next-transpile-modules": "^10.0.0",
"react": "18.2.0",
"react-dom": "18.2.0",
"react-html-parser": "^2.0.2",
"react-is": "18.0.0",
"react-markdown": "6.0.3",
"react-player": "2.11.0",
"react-responsive-carousel": "3.2.23",
"react-slick": "0.29.0",
"regenerator-runtime": "0.13.11",
"rehype-raw": "6.1.1",
"sharp": "0.31.3",
"slick-carousel": "1.8.1",
"styled-components": "5.3.6",
"swiper": "^8.4.5",
"tslib": "2.4.1"
},
"devDependencies": {
"@next/eslint-plugin-next": "12.2.2",
"@nrwl/cli": "15.4.3-beta.2",
"@nrwl/cypress": "15.4.3-beta.2",
"@nrwl/eslint-plugin-nx": "15.4.3-beta.2",
"@nrwl/express": "15.4.3-beta.2",
"@nrwl/jest": "15.4.3-beta.2",
"@nrwl/linter": "15.4.3-beta.2",
"@nrwl/node": "15.4.3-beta.2",
"@nrwl/nx-cloud": "15.0.2",
"@nrwl/react": "15.4.3-beta.2",
"@nrwl/web": "15.4.3-beta.2",
"@nrwl/workspace": "15.4.3-beta.2",
"@testing-library/jest-dom": "^5.16.4",
"@testing-library/react": "13.4.0",
"@testing-library/react-hooks": "8.0.1",
"@testing-library/user-event": "^14.3.0",
"@types/crypto-js": "4.1.1",
"@types/enzyme": "3.10.12",
"@types/express": "4.17.15",
"@types/jest": "^28.1.8",
"@types/node": "18.11.17",
"@types/react": "18.0.26",
"@types/react-dom": "18.0.10",
"@types/react-html-parser": "^2.0.2",
"@types/react-slick": "0.23.10",
"@typescript-eslint/eslint-plugin": "5.46.1",
"@typescript-eslint/parser": "5.46.1",
"@zarconontol/enzyme-adapter-react-18": "0.7.3",
"babel-jest": "28.1.3",
"cypress": "8.7.0",
"enzyme": "3.11.0",
"enzyme-to-json": "3.6.2",
"eslint": "8.30.0",
"eslint-config-next": "13.0.0",
"eslint-config-prettier": "8.5.0",
"eslint-plugin-cypress": "2.12.1",
"eslint-plugin-import": "2.26.0",
"eslint-plugin-jsx-a11y": "6.6.1",
"eslint-plugin-react": "7.31.11",
"eslint-plugin-react-hooks": "4.6.0",
"glob": "7.2.3",
"jest": "28.1.3",
"jest-environment-jsdom": "^29.3.1",
"jest-svg-transformer": "1.0.0",
"nx": "15.4.3-beta.2",
"prettier": "2.8.1",
"react-test-renderer": "18.0.0",
"sass": "1.55.0",
"ts-jest": "28.0.8",
"ts-node": "10.9.1",
"typescript": "4.9.4"
}
And the problem are:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: @testing-library/[email protected]
npm ERR! Found: @types/[email protected]
npm ERR! node_modules/@types/react
npm ERR! dev @types/react@"18.0.26" from the root project
npm ERR! @types/react@"*" from @types/[email protected]
npm ERR! node_modules/@types/enzyme
npm ERR! dev @types/enzyme@"3.10.12" from the root project
npm ERR! 4 more (@types/react-dom, @types/react-html-parser, ...)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peerOptional @types/react@"^16.9.0 || ^17.0.0" from @testing-library/[email protected]
npm ERR! node_modules/@testing-library/react-hooks
npm ERR! dev @testing-library/react-hooks@"8.0.1" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @types/[email protected]
npm ERR! node_modules/@types/react
npm ERR! peerOptional @types/react@"^16.9.0 || ^17.0.0" from @testing-library/[email protected]
npm ERR! node_modules/@testing-library/react-hooks
npm ERR! dev @testing-library/react-hooks@"8.0.1" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

any idea how to resolve this, help god please!

ljharb · 2023-01-14T05:14:32Z

@mauricioross the error is that you’re using testing library react hooks, which requires react 16 or 17 only, and react 18. You either have to downgrade react, or upgrade to a version of the react hooks testing library package that supports react 18.

sorinpav · 2023-11-10T13:14:37Z

@ljharb Surely this can't be the accepted solution - to downgrade React? We have the latest available version of @testing-library/react-hooks and still get that error.

Has anyone else looked into this?
I really believe this should not be closed as there isn't an acceptable solution given yet.

ljharb · 2023-11-10T15:44:41Z

If the latest version of RTL doesn’t say it’s compatible with react 18 (which i doubt) then the only solution is for that package to declare compatibility with react 18. Are you sure there’s not a later version?

flemton · 2024-08-28T11:46:27Z

For anyone coming from a web search, in this thread ljharb suggested installing an older version of react-test-renderer that's actually compatible w/ the issue creator's project's version of react by installing react-test-renderer@16 as a dev dep. So basically, you should run this command:

npm i react-test-renderer@SOME_VERSION --save-dev where SOME_VERSION is the general version of react that you're using in your project.

For instance, in my project I have react version 16.13.1 installed as listed on my package.json. So for me the command would be:

npm i [email protected] --save-dev

For me that fixed my issue with installing react-test-renderer & I was able to properly install it.

Edit: you might want to also edit the semantic version for react-test-renderer in your package.json so that's its a fixed version (e.g. "^16.13.1" => "16.13.1"). So that way the exact version you want always gets installed. Or better yet, use a ~ like ~16.13.1, which at least allows for minor patches.

This was what fixed mine, simply installing npm i --save-dev [email protected] fixed my issue and I was able to proceed to install testing-library and other dependencies

RobinWijnant added Bug thing that needs fixing Needs Triage needs review for next steps Release 7.x work is associated with a specific npm 7 release labels Nov 4, 2020

RobinWijnant closed this as completed Nov 4, 2020

darcyclarke added this to the OSS - Sprint 19 milestone Nov 16, 2020

csvan mentioned this issue Nov 22, 2020

NPM v7 needs webpack-dev-middleware@^4 - peerDep webpack v5 webpack/webpack-dev-server#2852

Closed

mongkuen mentioned this issue Aug 15, 2021

Peer dependency not fulfilled by gatsby 3 mongkuen/gatsby-plugin-root-import#14

Closed

Nyumat mentioned this issue Jan 27, 2024

Peer Dependency Build Fix Nyumat/NyumatFlix#22

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG] Unable to resolve peer dependency if version contains ">=" #2120

[BUG] Unable to resolve peer dependency if version contains ">=" #2120

RobinWijnant commented Nov 4, 2020

RobinWijnant commented Nov 4, 2020

ljharb commented Nov 4, 2020

isaacs commented Nov 6, 2020

isaacs commented Nov 13, 2020

csvan commented Nov 15, 2020

ljharb commented Nov 15, 2020

csvan commented Nov 15, 2020

ljharb commented Nov 15, 2020

abaidbutt commented Dec 10, 2020

csvan commented Dec 10, 2020

jaquinocode commented Mar 16, 2021 •

edited

Loading

ljharb commented Mar 16, 2021

jaquinocode commented Mar 16, 2021

ljharb commented Mar 16, 2021

jaquinocode commented Mar 16, 2021 via email

mauricioross commented Jan 14, 2023

ljharb commented Jan 14, 2023

sorinpav commented Nov 10, 2023

ljharb commented Nov 10, 2023

flemton commented Aug 28, 2024 •

edited

Loading

[BUG] Unable to resolve peer dependency if version contains ">=" #2120

[BUG] Unable to resolve peer dependency if version contains ">=" #2120

Comments

RobinWijnant commented Nov 4, 2020

Current Behavior:

Expected Behavior:

Steps To Reproduce:

Environment:

RobinWijnant commented Nov 4, 2020

ljharb commented Nov 4, 2020

isaacs commented Nov 6, 2020

isaacs commented Nov 13, 2020

csvan commented Nov 15, 2020

ljharb commented Nov 15, 2020

csvan commented Nov 15, 2020

ljharb commented Nov 15, 2020

abaidbutt commented Dec 10, 2020

csvan commented Dec 10, 2020

jaquinocode commented Mar 16, 2021 • edited Loading

ljharb commented Mar 16, 2021

jaquinocode commented Mar 16, 2021

ljharb commented Mar 16, 2021

jaquinocode commented Mar 16, 2021 via email

mauricioross commented Jan 14, 2023

ljharb commented Jan 14, 2023

sorinpav commented Nov 10, 2023

ljharb commented Nov 10, 2023

flemton commented Aug 28, 2024 • edited Loading

jaquinocode commented Mar 16, 2021 •

edited

Loading

flemton commented Aug 28, 2024 •

edited

Loading