fix: pass the scope of the package to pacote #158
Conversation
this allows npm-registry-fetch to correctly identify the registry associated with the request, which resolves the issues with incorrect auth being sent
|
🤦 Yes, lgtm. |
|
Just a thought, could we also fix this by changing const res = node.resolved ? this[_registryResolved](node.resolved)to const res = node.resolved ? `${node.name}@${this[_registryResolved](node.resolved)}` |
|
Yup, that also works since it allows npm-package-args to pick up the scope instead |
|
Ok. Might be safer since it won't clobber a |
Instead of manually setting a scope property that gets forwarded to pacote.extract, uses a spec that sets the resolved value so that pacote uses that instead. Addresses code review from #158
ruyadorno
force-pushed
the
nlf/fix-scoped-auth
branch
from
bfd3208 to
d5068c8
Compare
|
I addressed the CR and added a unit test to assert its expectation but I could not really reproduce the initial issues in a complete e2e test in my local machine, therefore I'm not a 100% sure this fixes the bugs as expected. Let me know if you have a repro around and can test it @nlf [edit] I ran a bunch of installs + cli tests on it and it doesn't look like this is going to break anything so I'm feeling more confident about landing it 😊 |
|
tested it against my reproduction and it does fix it 👍 i can't approve a PR i submitted apparently, but it's safe to consider this my approval |
this allows npm-registry-fetch to correctly identify the registry associated with the request, which resolves the issues with incorrect auth being sent
References
npm/cli#1959
npm/cli#1960
npm/cli#1800