This repository has been archived by the owner on Jan 20, 2022. It is now read-only.
fix: saveSpec should follow symlinks #126
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When saving the ideal tree metadata any installed directory provenant from a `file:` protocol was using the given filepath to store. This causes all future calls to `loadActual` to return invalid edges for loaded links since their fetchSpec won't match what was put in the stored metadata. This changes fixes it by making sure we properly follow symlink realpaths prior to saving the tree metadata.
ruyadorno
force-pushed
the
fix-save-spec-follow-symlinks
branch
from
7986acc to
7b7847d
Compare
|
closing this fix in favor of #129 which should be a more proper solution |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When saving the ideal tree metadata any installed directory provenant
from a
file:protocol was using the given filepath to store. Thiscauses all future calls to
loadActualto return invalid edges forloaded links since their fetchSpec won't match what was put in the
stored metadata.
This changes fixes it by making sure we properly follow symlink
realpaths prior to saving the tree metadata.