Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replace deprecated String.prototype.substr() #39

Closed
wants to merge 1 commit into from
Closed

fix: replace deprecated String.prototype.substr() #39

wants to merge 1 commit into from

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Oct 31, 2022 •
edited
Loading

Closes #38

@CommanderRoot
fix: replace deprecated String.prototype.substr()
8fca4c9 
.substr() is deprecated so we replace it with .slice() which works similarily but isn't deprecated

Signed-off-by: Tobias Speicher <[email protected]>
@lukekarrys lukekarrys requested a review from a team as a code owner October 31, 2022 21:03
@lukekarrys lukekarrys changed the title CommanderRoot refactor/rm deprecated substr fix: replace deprecated String.prototype.substr() Oct 31, 2022
@lukekarrys lukekarrys closed this Oct 31, 2022
@lukekarrys lukekarrys deleted the CommanderRoot-refactor/rm-deprecated-substr branch October 31, 2022 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lukekarrys @CommanderRoot