Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please publish a new version #83

Closed
jplatte opened this issue Aug 25, 2020 · 4 comments
Closed

Please publish a new version #83

jplatte opened this issue Aug 25, 2020 · 4 comments

Comments

@jplatte
Copy link
Contributor

jplatte commented Aug 25, 2020

In particular because of #74, #79.

@nox
Copy link
Owner

nox commented Sep 5, 2020

Doing this now.

nox added a commit that referenced this issue Sep 5, 2020
@nox nox closed this as completed Sep 5, 2020
@lovasoa
Copy link

lovasoa commented Sep 10, 2020

Hello !
Just a friendly reminder about version numbers:

  • you could have switched from 0.6.1 to 0.6.1, since the changes seem to be backwards compatible.
  • It would be nice if there were a CHANGELOG in the repo.
  • This crate is being used by many other major stable crates, such as actix-web, and is thus being used in production by a lot of people. Would you consider switching to 1.x and guarantee backward compatibility ?

https://semver.org/

@nickelc
Copy link
Contributor

nickelc commented Sep 10, 2020

* you could have switched from 0.6.1 to 0.6.1, since the changes seem to be backwards compatible.

The changes are not backwards compatible because form_urlencoded::Serializer (url::form_urlencoded::Serializer with v0.6) is part of the public api.

@nox
Copy link
Owner

nox commented Sep 10, 2020

It would be nice if there were a CHANGELOG in the repo.

Patches welcome.

This crate is being used by many other major stable crates, such as actix-web, and is thus being used in production by a lot of people. Would you consider switching to 1.x and guarantee backward compatibility ?

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants